Summary: | Kgpg startup crash QSortFilterProxyModel and _q_sourceLayoutChanged. | ||
---|---|---|---|
Product: | [Applications] kgpg | Reporter: | Alexander <alexander.nofamilyname> |
Component: | general | Assignee: | Rolf Eike Beer <kde> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | faure |
Priority: | NOR | ||
Version: | 2.6.x | ||
Target Milestone: | --- | ||
Platform: | Debian unstable | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8.1 | |
Sentry Crash Report: | |||
Attachments: | valgrind log |
Description
Alexander
2012-02-14 19:16:01 UTC
Created attachment 68800 [details]
valgrind log
David, when I compare this backtrace to the very first one in bug 254090 I see it's exactly the same stack (just some moved line numbers). Compare valgrind logs, not backtraces. The "usage that crashes" can be the same, but if the cause for the deletion of the data is different, then it's a different bug. After more discussion on IRC, the issue is the fixPersistentIndexes() code in kgpg, so reassigning this back. Git commit 751c40508de14dfc4f756ec6e5388d849d63004f by Rolf Eike Beer. Committed on 15/02/2012 at 20:53. Pushed by dakon into branch 'KDE/4.8'. fix crashes on model changes QAbstractItemModel::changePersistentIndex() is heavily underdocumented, so I probably got it wrong. Use beginResetModel()/endResetModel() to guard "global" changes in the model instead of layoutAboutToBeChanged()/layoutChanged(). This should hopefully get rid of all the spurious crashes deep in the Qt model implementation. Related: bug 254090 FIXED-IN:4.8.1 M +6 -28 model/kgpgitemmodel.cpp M +1 -2 model/kgpgitemmodel.h http://commits.kde.org/kgpg/751c40508de14dfc4f756ec6e5388d849d63004f |