Bug 293520

Summary: Plasmoid is acking messages
Product: [Unmaintained] telepathy Reporter: David Edmundson <kde>
Component: chat-plasmoidAssignee: Telepathy Bugs <kde-telepathy-bugs>
Status: RESOLVED NOT A BUG    
Severity: normal CC: kde
Priority: NOR    
Version: unspecified   
Target Milestone: 0.4.0   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description David Edmundson 2012-02-07 10:23:22 UTC
Whilst the plasmoid is an observer it should _not_ be acking messages ever.

It blocks messages getting to the text ui.
Comment 1 David Edmundson 2012-02-08 00:15:04 UTC
Relevant quote from docs.

"Observers must not carry out actions that exactly one process must take responsibility for (e.g. acknowledging text messages, or carrying out the actual file transfer), since arbitrarily many observers can be activated for each channel. The handler is responsible for such tasks."

Though personally, having thought about it this seems like a sensible thing for the plasmoid to do so I'm not sure. Will talk to tp people.
Comment 2 Lasath Fernando 2012-02-08 02:16:32 UTC
Well, the reason it acknowledges is because it was designed to be a handler. And I think we should make sure it is before we release, rather than stopping it from acking.
Comment 3 Lasath Fernando 2012-02-15 12:59:24 UTC
Now that it is a handler, can this bug be closed?
Comment 4 David Edmundson 2012-02-15 13:14:36 UTC
We still become an observer after we delegate and according to the spec we shouldn't ack then.

But now that Guillaume Desmottes said "gnome shell acks message" even when it's an observer, we can close it. It's still against the spec, but doing the same as telepathy people so it's fine.

(http://www.mail-archive.com/telepathy@lists.freedesktop.org/msg05553.html)