| Summary: | Fix udisk/upower property queries done by solid | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] solid | Reporter: | Stefan Brüns <stefan.bruens> |
| Component: | general | Assignee: | Lukáš Tinkl <lukas> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cfeck, germano.massullo, kde, lukas, rudd-o |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdelibs/764f7cdce7b3e54cbe8bdeccc20e85cd6a0b4aea | Version Fixed In: | |
| Attachments: | Proposed patch | ||
Please FIX, this bug is still present in kde 4.9 and spamming syslogs everywhere in the world. Is it related to https://bugzilla.redhat.com/show_bug.cgi?id=743779 ? (In reply to comment #2) > Is it related to > https://bugzilla.redhat.com/show_bug.cgi?id=743779 ? Very likely ... The patch is ok'ed in https://git.reviewboard.kde.org/r/103902/ , and should be applied to 4.8.5 and 4.9.0 Git commit 5d177ee7aaf40df16c88f8ee602819159b747f9d by Lukas Tinkl. Committed on 17/07/2012 at 12:48. Pushed by lukas into branch 'KDE/4.9'. Fix solid udisk/upower property queries REVIEW: 103902 M +1 -0 solid/solid/backends/udisks/udisksdevice.cpp M +6 -0 solid/solid/backends/udisks/udisksmanager.cpp M +1 -0 solid/solid/backends/upower/upowerdevice.cpp M +6 -0 solid/solid/backends/upower/upowermanager.cpp http://commits.kde.org/kdelibs/5d177ee7aaf40df16c88f8ee602819159b747f9d Git commit 764f7cdce7b3e54cbe8bdeccc20e85cd6a0b4aea by Lukas Tinkl. Committed on 17/07/2012 at 12:48. Pushed by lukas into branch 'KDE/4.8'. Fix solid udisk/upower property queries REVIEW: 103902 M +1 -0 solid/solid/backends/udisks/udisksdevice.cpp M +6 -0 solid/solid/backends/udisks/udisksmanager.cpp M +1 -0 solid/solid/backends/upower/upowerdevice.cpp M +6 -0 solid/solid/backends/upower/upowermanager.cpp http://commits.kde.org/kdelibs/764f7cdce7b3e54cbe8bdeccc20e85cd6a0b4aea |
Created attachment 68580 [details] Proposed patch Version: 4.8 (using KDE 4.8.0) OS: Linux Currently, both backends have two identical problems: 1. GetAll() requires the interface name as parameter 2. The RootDevice node is treated as a U{Disks/Power}Device node. Reproducible: Always Steps to Reproduce: use e.g. UDisksManager::devicesFromQuery("", Solid::DeviceInterface::StorageAccess) as the udi "/org/freedesktop/UDisks" is added to m_deviceCache, it is used in the foreach loop Expected Results: no Text