| Summary: | Dolphin repeats a rearrange action infinitely in some cases | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Denis M. (Phr33d0m) <god> |
| Component: | view-engine: general | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | xgdgsc |
| Priority: | NOR | Keywords: | usability |
| Version: | 2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8.1 | |
| Attachments: |
Video from the description which shows dolphin's described behaviour.
State before infinite loop Example directory |
||
|
Description
Denis M. (Phr33d0m)
2012-02-04 19:21:49 UTC
I forgot to add something very important: this occurs when dolphin is maximized and there is *more* than one tab opened. If there is only 1 tab there is are no problems. Created attachment 68494 [details]
State before infinite loop
Created attachment 68495 [details]
Example directory
Thanks for the report, I could reproduce the issue with the attached example directory. (Internal notes: The screenshot shows the state with the attached example directory where no infinite loop is done. Now decreasing the width of the window will result in an infinite loop because the scrollbar results in a decreased height and this results in a changed layout which (now) again does not need a scrollbar anymore). Another internal note: When decreasing the width the new layout will be a e This is a longer label for the compact view h x b f This is a longer label for the compact view i c g Very long... (and yes: I forgot the 'd' ;-) *** Bug 293343 has been marked as a duplicate of this bug. *** Git commit 81034de5074071d45bd4da212c80fb3dd5ea4933 by Peter Penz. Committed on 05/02/2012 at 19:14. Pushed by ppenz into branch 'KDE/4.8'. Fix potential endless loop in layout Usecase: - No scrollbar is shown - Window size will be decreased so that a scrollbar gets necessary The decreased window size minus the space required for the scrollbar results in a relayout of the items. In 99 % of all cases a decreased window size won't result in showing more items in parallel in comparison to a larger window size. However in the remaining 1 % this can happen (e.g. see bug 293318 for a sample). This results in an endless loop as now no scrollbar is required anymore, the layout changes again, the scrollbar is required again, ... FIXED-IN: 4.8.1 M +34 -0 dolphin/src/kitemviews/kitemlistcontainer.cpp M +7 -0 dolphin/src/kitemviews/kitemlistcontainer.h M +13 -0 dolphin/src/kitemviews/kitemlistview.cpp M +8 -0 dolphin/src/kitemviews/kitemlistview.h http://commits.kde.org/kde-baseapps/81034de5074071d45bd4da212c80fb3dd5ea4933 Git commit dd917bf572f7fa79c3599f717bf78d7088648bfa by Peter Penz. Committed on 05/02/2012 at 19:14. Pushed by ppenz into branch 'master'. Fix potential endless loop in layout Usecase: - No scrollbar is shown - Window size will be decreased so that a scrollbar gets necessary The decreased window size minus the space required for the scrollbar results in a relayout of the items. In 99 % of all cases a decreased window size won't result in showing more items in parallel in comparison to a larger window size. However in the remaining 1 % this can happen (e.g. see bug 293318 for a sample). This results in an endless loop as now no scrollbar is required anymore, the layout changes again, the scrollbar is required again, ... FIXED-IN: 4.8.1 M +34 -0 dolphin/src/kitemviews/kitemlistcontainer.cpp M +7 -0 dolphin/src/kitemviews/kitemlistcontainer.h M +13 -0 dolphin/src/kitemviews/kitemlistview.cpp M +8 -0 dolphin/src/kitemviews/kitemlistview.h http://commits.kde.org/kde-baseapps/dd917bf572f7fa79c3599f717bf78d7088648bfa |