Bug 293201

Summary:	Blank page displayed in some 404 situations
Product:	[Websites] docs.kde.org	Reporter:	T.C. Hollingsworth <tchollingsworth>
Component:	docs.kde.org	Assignee:	Documentation Editorial Team <kde-doc-english>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Unspecified
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	display a helpful message on 404

Description T.C. Hollingsworth 2012-02-03 12:37:09 UTC

A blank page is shown on some 404s on docs.kde.org instead of a helpful error message.

Displays an error page:
http://docs.kde.org/$branch/nonexistent.html
http://docs.kde.org/$branch/$lang/nonexistent.html

Displays a blank page:
http://docs.kde.org/nonexistent.html
http://docs.kde.org/$branch/$lang/nonexistant
http://docs.kde.org/$branch/$lang/$application/nonexistent.html

Since it's showing a blank page instead of a httpd default 404 error, I'm guessing that trunk/www/areas/docs/404.php is being displayed, but the path in 'include("media/404.php");' at the bottom is incorrect.  If the directory structure on the server is the same as it is in SVN, it should be 'include("../../media/404.php");'.

Comment 1 T.C. Hollingsworth 2012-02-03 12:58:34 UTC

Created attachment 68462 [details]
display a helpful message on 404

Looking more closely, it seems that "media/404.php" in Capacity doesn't display anything; it just redirects for some common mistakes.  So the include probably isn't the problem.

I guess if we want a helpful 404 message we need to display one ourselves.  This patch should do the trick.

Comment 2 Burkhard Lück 2012-02-03 15:16:00 UTC

SVN commit 1277939 by lueck:

apply patch by T.C. Hollingsworth to display a helpful message on 404

 M  +4 -1      404.php  
 M  +13 -0     index.php  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1277939

Comment 3 Burkhard Lück 2012-02-03 15:56:30 UTC

Checked the broken link from https://bugs.kde.org/show_bug.cgi?id=292560 with the patch from Comment #2:

2)kde-baseapps/kwrite/view-menu.html link The Editor Component Command Line

Get a helpfull error message now.

From my pov this bug is fixed.

Comment 4 T.C. Hollingsworth 2012-02-03 19:55:49 UTC

Looks good to me too.  Thanks for taking care of this so quickly!  :-)