| Summary: | Drag&drop files in dolphin doesnt preserve origin | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Zé <mmodem00> |
| Component: | panels: folders | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | emmanuelpescosta099, gedgon, peter.penz19 |
| Priority: | NOR | ||
| Version: | 2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-baseapps/f52fc1425263c2e9ca0f905e9c3d1264e4a41aae | Version Fixed In: | 4.9.2 |
| Sentry Crash Report: | |||
|
Description
Zé
2012-02-03 11:52:05 UTC
Please disable the checkbox "[ ] Open folders during drag operations" in the settings dialog (Navigation), then the folder won't get opened. I'm not 100 % sure whether I understood your report correctly - please reopen it in case if I missunderstood something (... and probably provide a screenshot). Thanks. That option "Open folders during drag operations" was not activated/selected. You have for example the folder ~/Documents where you have severall files, and you want to move a file to the folder ~/Images, so in dolphin you have in right panel all files from the folder ~/Documents and you select a file foo.txt and drag it into the folder ~/Images, when you put the mouse over the folder ~/Images (folders panel) happens that the contents from the folder ~/Images appear in the right panel. But that should not happen, it should continue to show the contents of the folder ~/Documents (from you selected and dragged the file foo.txt). Is not possible to create screenshots of tis situations, a video could be the solution but since its a bug file it can be attached here. Thats why i mailed you asking you to chat in freenode in where was possible to send you a video. But i think now with this description you will be able to understand the problem. I could reproduce the issue now but only because I knew of your other bug reports that you have activated the "Folders Panel": Please try to use the terms that are in the menus of Dolphin to explain a bug. "right panel" and "left panel" are not sufficient as description as the position of panels can be configured by the users. If in doubt please just attach a screenshot. Example of a sufficient bug description: Precondition: - Folders Panel is enabled - View mode is set to "icons" - Have a directory ~/Documents with some files - Have a directory ~/Images with sub-directories Steps to reproduce: - In the view open a directory ~/Documents - Drag the file ~/Documents/x from the view to ~/Images in the Folders Panel and don't release the mouse button (= don't drop) Result: The folder ~/Images gets expanded in the Folders Panel - Move the mouse above the sub-folder x of ~/Images and don't release the mouse button Actual result: - The view content will show ~/Images/x Expected result: - The view content won't change I'd kindly ask in future to just use this pattern (Precondition, Steps to reproduce, Actual result, Expected result) for bug-reports. Thanks. PS: Regarding the video: It is not necessary anymore but for future issues please just upload them to e.g. YouTube. It takes only a few minutes to create an account. Thanks. Hi Peter, I'm little confused by Zé's bug description. Is this the same issue what is shown on video? http://youtu.be/VXRtphAxJX8 @Gedgon: Yes, it is the same issue as shown in the video :-) Resetting assignee to default as per bug #305719 review-request: https://git.reviewboard.kde.org/r/106381/ @Zé: Can you please test it? :) Currently i have no machine with kde compiled from sources and i have very litle time to do a new kde build for some time, so i would kindly ask if other could test your changes. Git commit f52fc1425263c2e9ca0f905e9c3d1264e4a41aae by Emmanuel Pescosta. Committed on 19/09/2012 at 19:00. Pushed by emmanuelp into branch 'KDE/4.9'. Fixes Bug 293200 - Drag&drop files in dolphin doesnt preserve origin Patch 106381 Comment #3: When "Open folders during drag operations" is enabled, two things happen, both in the DolphinView and in the Folders Panel: 1) When hovering a folder that can be expanded (this is the case for folders with sub-folders in the Folders Panel and in the DolphinView if in Details View mode), toggle its "expanded" state. 2) When hovering a folder that can not be expanded (i.e., a folder without sub-folders or any folder in Icons or Compact View), open this folder in the DolphinView via the KItemListController's itemActivated(int) signal. The bug described in bug 293200 comment 3 is that 1) is always wanted, but 2) is not wanted for the Folders Panel. FIXED-IN: 4.9.2 M +12 -1 dolphin/src/kitemviews/kitemlistcontroller.cpp M +10 -0 dolphin/src/kitemviews/kitemlistcontroller.h M +1 -0 dolphin/src/panels/folders/folderspanel.cpp http://commits.kde.org/kde-baseapps/f52fc1425263c2e9ca0f905e9c3d1264e4a41aae |