Summary: | Brush rotation should be absolute, not relative to canvas rotation | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | animtim |
Component: | Usability | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | GBirdboy, halla, lukast.dev |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/kde/krita/commit/1a9077c3df45438350b1912009ea0ddaf0fb0fee | Version Fixed In: | |
Sentry Crash Report: |
Description
animtim
2012-01-28 21:44:15 UTC
Yes, I see... I think it's always been this way, though! Yes indeed, it's always been like that in Krita, just I didn't notice it until now. (I guess I didn't notice it in 2.3 as we didn't have ascension/declination sensors yet, and I used mostly round brushes) Git commit 5c91a3e0c9597de7e8dd320c60f3f56881d4b5ce by Lukáš Tvrdý. Committed on 26/05/2012 at 15:06. Pushed by lukast into branch 'master'. Make brush rotation absolute to canvas rotation o pass the canvas rotation to rotation sensor and remap the rotation accoring current status of the canvas o also rendering of the brush outline has to respect canvas rotation M +11 -0 krita/image/brushengine/kis_paintop_settings.cpp M +3 -0 krita/image/brushengine/kis_paintop_settings.h M +2 -2 krita/plugins/paintops/defaultpaintops/brush/kis_brushop.cpp M +10 -3 krita/plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp M +3 -0 krita/plugins/paintops/libpaintop/kis_pressure_rotation_option.h M +5 -0 krita/ui/canvas/kis_canvas2.cpp M +2 -0 krita/ui/canvas/kis_canvas2.h M +6 -0 krita/ui/tool/kis_tool_freehand.cc http://commits.kde.org/calligra/5c91a3e0c9597de7e8dd320c60f3f56881d4b5ce Fix confirmed by Animtim
> (04:24:15 PM) Animtim: LukasT: ok you can close the bug 292726, thank
> youuu :)
This bug is back. *** Bug 411078 has been marked as a duplicate of this bug. *** Maybe caused by Git commit c74ddaf2991833c7c587dec47f53456ec36304e2 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 02/08/2019 at 08:26. Pushed by rempt into branch 'krita/4.2'. Fix Tangent-Normal brush on rotated/mirrored canvas (and also in multihand brush) Now the canvas rotation/mirroing code is fully ported to the new API, by passing via KisPaintInformation instead of paintop settings' temporary properties. BUG:404408 ? Dmitry confirms this suspicion. Git commit d8f90d4a8968e50e709833de8543776860dcbbcb by Dmitry Kazakov. Committed on 22/08/2019 at 10:03. Pushed by dkazakov into branch 'master'. [REGRESSION] Fix absolute brush rotation on rotated canvas The regression was caused by c74ddaf2991833c7c587dec47f53456ec36304e2 M +1 -1 plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp https://invent.kde.org/kde/krita/commit/d8f90d4a8968e50e709833de8543776860dcbbcb Git commit 1a9077c3df45438350b1912009ea0ddaf0fb0fee by Dmitry Kazakov. Committed on 22/08/2019 at 10:07. Pushed by dkazakov into branch 'krita/4.2'. [REGRESSION] Fix absolute brush rotation on rotated canvas The regression was caused by c74ddaf2991833c7c587dec47f53456ec36304e2 M +1 -1 plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp https://invent.kde.org/kde/krita/commit/1a9077c3df45438350b1912009ea0ddaf0fb0fee |