Bug 292698

Summary:	dolphin changes icon size and icon spacing by itself, no way to disable
Product:	[Applications] dolphin	Reporter:	Tanja Schulte <nightowl>
Component:	view-engine: general	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugzilla
Priority:	NOR
Version:	2.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	4.8.1
Sentry Crash Report:

Description Tanja Schulte 2012-01-28 15:58:54 UTC

Version: 2.0 (using KDE 4.8.0)
OS: Linux

After I updated from KDE SC 4.7 to 4.8 dolphin now changes the icon size in the file window automatically on its own and ignores the icon size I have set. It's only me, the user, who knows which icon size is best for me in general and for a specific purpose, so I want a fixed icon size once I set it: fixed icon size, fixed icon space vertically, fixed icon space horizontally, clear and not changing view, every icon where I expect it. Please add an option to get the former behaviour with fixed icons size and fixed icon spacing.

Reproducible: Always

Steps to Reproduce:
Open dolphin switch to any directory in icon mode - and voilà, the icon size adjusts as does the space between the icons. Go to dolphin's view mode settings, adjust the length of the text and voilà, the icon size adjusts.

Actual Results:
Dolphin "thinks" it knows what I want but I don't. It changes the icon size and alignement on its own. When I change the text length in dolphin's view settings dolphin does not change the text length but changes the icon size! I choose short text to get more icons in the view and to minimize the space between the icons and dolphin increases the icons. Very unpolite behaviour.

Expected Results:
When I set short text in dolphin's icon view settings I expect to get short text and not bigger icons. The icon size must stay at all means. It must be possible to change the shown text length without dolphin ignoring the set icon size. Both should be independent from each other at it was. I expect an option to turn that behaviour completely off, as it is not only irritating but unpolite.

OS: Linux (i686) release 3.0.0-16-generic
Compiler: gcc

Comment 1 Peter Penz 2012-01-28 18:51:19 UTC

Hm, either an information is missing in this report or I don't understand something as I cannot reproduce the issue: The icon-size stays always the same here as expected. It might be an issue with an old dolphinrc file - is the issue "solved" if you remove the file ~/.kde4/share/config/dolphinrc? Attention: Please backup this file as removing it will "reset" Dolphin to the default settings. Normally after upgrading Dolphin should have reset the icon sizes itself but probably there might be an upgrade issue.

Comment 2 Janet 2012-01-29 02:27:31 UTC

I had the same problem after upgrading to 4.8 in Kubuntu. I changed a lot between text length short, medium, long and back to find an appropriate view. And every time the icon size changed when I changed the text length. Also dolphin ignored the icon size in its settings. Now it seems to accept the icon size and remember it. 

Maybe it is a kind of misunderstanding. The icon size slider in the status bar now behaves different than in former dolphin versions. In dolphin 1.x using the slider also adjusted the icon size slider in the corresponding view mode in dolphin's settings. It does not do this in dolphin 2. That might result in thinking that dolphin changes the icon size "on its own". 

Szenario dolphin 1: In dolphin's settings the icon size for icon view mode is set to 64. I use the slider in the *status bar* to set the icons in a directory to size 80. I open dolphin's settings and the icons size for the icon view mode is set to 80. I change the text length and the icons stay at size 80. 

Same szenario in dolphin 2: The icon size for icon view mode is set to 64. I use the status bar slider to set them to 80. I open the settings for icon view mode - and the icon size there is still 64 (which I don't realize). I change the text length - and all icons in the folder shrink to 64 though I expect they stay at 80.

Comment 3 Peter Penz 2012-01-29 08:14:45 UTC

> The icon size slider in the status ba
> now behaves different than in former dolphin versions.
> In dolphin 1.x using the slider also adjusted the icon size
> slider in the corresponding view mode in
> dolphin's settings. It does not do this in dolphin 2. That might
> result in thinking that dolphin changes the icon size "on its own".

@Janet: Thanks, this is a good hint and the root cause of the issue :-) So the issue occurs if the size is changed first with the slider in the statusbar and afterwards in the settings dialog.

Comment 4 Peter Penz 2012-01-30 15:44:24 UTC

Git commit c924a01b11077cd9a934ca193caec3dfed7722bd by Peter Penz.
Committed on 30/01/2012 at 16:36.
Pushed by ppenz into branch 'master'.

Synchronize view-mode settings before the settings dialog gets opened
FIXED-IN: 4.8.1

M  +6    -3    dolphin/src/dolphinmainwindow.cpp
M  +1    -1    dolphin/src/dolphinpart.cpp
M  +3    -3    dolphin/src/dolphinviewcontainer.cpp
M  +1    -1    dolphin/src/dolphinviewcontainer.h
M  +3    -1    dolphin/src/settings/viewmodes/viewsettingstab.cpp
M  +1    -1    dolphin/src/statusbar/dolphinstatusbar.cpp
M  +1    -1    dolphin/src/statusbar/dolphinstatusbar.h
M  +10   -5    dolphin/src/views/dolphinitemlistcontainer.cpp
M  +2    -4    dolphin/src/views/dolphinitemlistcontainer.h
M  +8    -2    dolphin/src/views/dolphinview.cpp
M  +8    -4    dolphin/src/views/dolphinview.h

http://commits.kde.org/kde-baseapps/c924a01b11077cd9a934ca193caec3dfed7722bd

Comment 5 Peter Penz 2012-01-30 15:44:49 UTC

Git commit 02e3235275ca2d58daa4fb5ca16b2ffc63016fd7 by Peter Penz.
Committed on 30/01/2012 at 16:36.
Pushed by ppenz into branch 'KDE/4.8'.

Synchronize view-mode settings before the settings dialog gets opened
FIXED-IN: 4.8.1

M  +6    -3    dolphin/src/dolphinmainwindow.cpp
M  +1    -1    dolphin/src/dolphinpart.cpp
M  +3    -3    dolphin/src/dolphinviewcontainer.cpp
M  +1    -1    dolphin/src/dolphinviewcontainer.h
M  +3    -1    dolphin/src/settings/viewmodes/viewsettingstab.cpp
M  +1    -1    dolphin/src/statusbar/dolphinstatusbar.cpp
M  +1    -1    dolphin/src/statusbar/dolphinstatusbar.h
M  +10   -5    dolphin/src/views/dolphinitemlistcontainer.cpp
M  +2    -4    dolphin/src/views/dolphinitemlistcontainer.h
M  +8    -2    dolphin/src/views/dolphinview.cpp
M  +8    -4    dolphin/src/views/dolphinview.h

http://commits.kde.org/kde-baseapps/02e3235275ca2d58daa4fb5ca16b2ffc63016fd7

Comment 6 Tanja Schulte 2012-04-01 12:53:46 UTC

Thanks Janet for being my eyes and brain ;) and thanks Peter for fixing this!