Bug 292667

Summary: Drag-and-drop of layers works wrong in some cases
Product: [Applications] krita Reporter: Dmitry Kazakov <dimula73>
Component: DockersAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:

Description Dmitry Kazakov 2012-01-28 09:22:28 UTC 
Create a following image:

+-+-Group4
| +-Paint6
| +-Paint5
|
+-Paint3
+-Paint2
+-Paint1


Testcases:
1) Try to drop Paint2 below Paint5 inside Group4. Nothing happens.
2) Try to drop Paint2 below Paint6 inside Group4. It is moved above Paint3 and still belongs to the root layer.

I'm going to fix it as part of the changes to KisNodeModel.
Comment 1 Dmitry Kazakov 2012-02-03 16:13:52 UTC 
Git commit add6b81b9e1e9c9022fee321b85c1b1e21e2bc60 by Dmitry Kazakov.
Committed on 03/02/2012 at 18:00.
Pushed by dkazakov into branch 'shapes-as-node-model-kazakov'.

Fixed Drag & Drop in the Layer Box. Now it works perfectly!

Yeah, like in all the other applications!
Related: bug 292669

M  +6    -5    krita/image/commands/kis_image_layer_move_command.cpp
M  +2    -0    krita/image/commands/kis_image_layer_move_command.h
M  +12   -0    krita/image/kis_base_rects_walker.h
M  +5    -7    krita/image/kis_merge_walker.cc
M  +1    -3    krita/image/kis_node_facade.cpp
M  +10   -15   krita/image/kis_refresh_subtree_walker.h
M  +114  -11   krita/image/tests/kis_walkers_test.cpp
M  +1    -0    krita/image/tests/kis_walkers_test.h
M  +4    -4    krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp
M  +12   -0    krita/ui/kis_node_manager.cpp
M  +14   -0    krita/ui/kis_node_manager.h
M  +48   -29   krita/ui/kis_node_model.cpp
M  +7    -4    krita/ui/kis_node_model.h

http://commits.kde.org/calligra/add6b81b9e1e9c9022fee321b85c1b1e21e2bc60