| Summary: | KHelpCenter crash in KHC::Navigator::selectItem | ||
|---|---|---|---|
| Product: | [Applications] khelpcenter | Reporter: | Christopher Yeleighton <giecrilj> |
| Component: | general | Assignee: | Documentation Editorial Team <kde-doc-english> |
| Status: | RESOLVED DOWNSTREAM | ||
| Severity: | crash | CC: | wstephenson, xxzlmhs |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | New crash information added by DrKonqi | ||
|
Description
Christopher Yeleighton
2012-01-27 16:19:57 UTC
There has to be something broken in OpenSuse, your backtrace says that line 326 of navigator.cpp called to currentItem, but the line 326 of navigator.cpp does call to currentItem as you can see in https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/v4.7.2/entry/khelpcenter/navigator.cpp#L326 Adding Will to see if he can shed some light as to why the opensuse sources do not match with KDE ones. --- khelpcenter/navigator.cpp.orig
+++ khelpcenter/navigator.cpp
@@ -65,6 +65,7 @@
#include "searchwidget.h"
#include "searchengine.h"
#include "docmetainfo.h"
+#include "docentry.h"
#include "docentrytraverser.h"
#include "glossary.h"
#include "toc.h"
@@ -268,6 +269,11 @@ void Navigator::createItemFromDesktopFil
const QString &file )
{
KDesktopFile desktopFile( file );
+
+ if (!DocEntry::isForRunningDesktopEnvironment(desktopFile)) {
+ return;
+ }
+
QString docPath = desktopFile.readDocPath();
if ( !docPath.isNull() ) {
// First parameter is ignored if second is an absolute path
@@ -310,6 +316,9 @@ void Navigator::selectItem( const KUrl &
{
alternativeURL.setQuery("anchor="+url.ref());
alternativeURL.setRef(QString());
+ } else if (url.url().endsWith("/index.html"))
+ {
+ alternativeURL = KUrl (url.url().left (url.url().length() - strlen ("/index.html")));
}
// If the navigator already has the given URL selected, do nothing.
Index: khelpcenter/navigatoritem.cpp
Bug Novell 743932 Submitted
Created attachment 151676 [details]
New crash information added by DrKonqi
khelpcenter (5.8.22041) using Qt 5.15.4
KDE helpceter start automatically (when I am setting up the shortcut of plasma?) and restart again and again once I close it.
-- Backtrace (Reduced):
#4 0x00007fcd4f65e381 in QItemSelectionModel::currentIndex() const () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#5 0x00007fcd505cfdd1 in QAbstractItemView::currentIndex() const () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#6 0x00007fcd50653dd4 in QTreeWidget::currentItem() const () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
[...]
#11 0x00007fcd50e0eee7 in KDBusService::activateRequested(QStringList const&, QString const&) () from /lib/x86_64-linux-gnu/libKF5DBusAddons.so.5
#12 0x00007fcd50e1188e in KDBusService::CommandLine(QStringList const&, QString const&, QMap<QString, QVariant> const&) () from /lib/x86_64-linux-gnu/libKF5DBusAddons.so.5
|