Bug 292574

Summary:	Icon text is always visible
Product:	[Applications] okular	Reporter:	lucapas <pasqualini.luca>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cfeck
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	4.8.1
Sentry Crash Report:

Description lucapas 2012-01-27 11:25:26 UTC

Version:           unspecified (using KDE 4.7.4) 
OS:                Linux

If I hide icon text, it is visible reopening Okular.

Reproducible: Always

Steps to Reproduce:
Hide icon text of the bar

Actual Results:  
Reopening Okular it will visible again.

Expected Results:  
That keeps changing

OS: Linux (x86_64) release 3.0.0-15-generic
Compiler: gcc

Comment 1 Albert Astals Cid 2012-01-27 11:52:32 UTC

Which bar?

Comment 2 lucapas 2012-01-27 15:57:01 UTC

Il 27/01/2012 12:52, Albert Astals Cid ha scritto:
> Which bar?

The toolbar.

I'm Italian and I do a lot of difficulty with English, sorry.

Comment 3 Albert Astals Cid 2012-01-27 16:57:21 UTC

Works here, which distro are you using?

Comment 4 Christoph Feck 2012-01-27 22:55:56 UTC

(with today's master, running okular as standalone)

Well, it works when using the "Configure Toolbars" > Change Text ... button, but it does not work when right-clicking on a toolbar button. Here, I only get a okular(24012)/kdeui (kdelibs): No such XML file "okularui.rc" message.

Comment 5 Albert Astals Cid 2012-01-28 12:51:19 UTC

@Christoph What you say is something totally different to what lucapas is saying. Isn't it?

Comment 6 Albert Astals Cid 2012-01-28 12:54:25 UTC

Ok, it's different but probably caused by the same issue, I'll have a look later.

Comment 7 Albert Astals Cid 2012-01-28 15:29:10 UTC

There is a fix for this issue in https://git.reviewboard.kde.org/r/103812/ since it is kdelibs related i need someone else to approve the fix before i can commit it to the repository

Comment 8 lucapas 2012-01-29 00:22:48 UTC

Il 27/01/2012 17:57, Albert Astals Cid ha scritto:
> https://bugs.kde.org/show_bug.cgi?id=292574
>
>
>
>
>
> --- Comment #3 from Albert Astals Cid<tsdgeos terra es>   2012-01-27 16:57:21 ---
> Works here, which distro are you using?
>

Kubuntu 11.10 64 bit.

Comment 9 lucapas 2012-01-29 00:41:01 UTC

Il 28/01/2012 16:29, Albert Astals Cid ha scritto:
> https://bugs.kde.org/show_bug.cgi?id=292574
>
>
>
>
>
> --- Comment #7 from Albert Astals Cid<tsdgeos terra es>   2012-01-28 15:29:10 ---
> There is a fix for this issue in https://git.reviewboard.kde.org/r/103812/
> since it is kdelibs related i need someone else to approve the fix before i can
> commit it to the repository
>

Sorry, but I am not able to install the patch.

Comment 10 Albert Astals Cid 2012-01-29 14:37:54 UTC

@lucpas: No worries, i am not asking you to install it

Comment 11 Albert Astals Cid 2012-02-21 23:11:10 UTC

Git commit 576e13d355c34858e8a254a28a100a8b9f7876a8 by Albert Astals Cid.
Committed on 22/02/2012 at 00:09.
Pushed by aacid into branch 'KDE/4.8'.

Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

Acked by David Faure
REVIEW: 103812
FIXED-IN: 4.8.1

M  +41   -13   kdeui/widgets/ktoolbar.cpp
M  +10   -1    kdeui/widgets/ktoolbar.h
M  +1    -1    kdeui/xmlgui/kxmlguibuilder.cpp
M  +11   -0    kdeui/xmlgui/kxmlguifactory_p.cpp

http://commits.kde.org/kdelibs/576e13d355c34858e8a254a28a100a8b9f7876a8