Summary: | Amarok crashed when quitting while "fetching for missing covers" [@ CoverFetcher::~CoverFetcher] | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Elez J. Shenhar <elezsh> |
Component: | Tools/Cover Manager | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | bart.cerneels, hessijames, periliocastrol, stuffcorpse |
Priority: | NOR | ||
Version: | 2.5.90 (2.6 beta) | ||
Target Milestone: | 2.6 | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/amarok/2b20b48c7bb67e74c4d1d1a964b9d1006a5356bb | Version Fixed In: | 2.7 |
Description
Elez J. Shenhar
2012-01-27 06:56:03 UTC
Do you have any non-standard configuration? I can't reproduce this here at all: - Start Cover Manager - Download missing covers - Quit Amarok while the cover manager is still working I see no crash, no matter how often I tried, using Amarok 2.5-git with KDE 4.8, Qt 4.7.4 on Kubuntu 11.10. Collection is on an external USB hard disk used as the main collection. Your crash appears to be in CompoundProgressBar::childBarFinished, could you please remove the amarok* configuration files in $HOME/.kde/share/config/ and try again? I removed the Amarok config files, and still reproduced it in the same scenario. I tried again, this time removing not only the config files but also the $HOME/.kde/share/apps/amarok/ folder as well - still reproduced. I tried, in "Select your Amazon locale", to select United States, and I also tried United Kingdom - same crash. My music is stored in an internal HD (not the one used for $HOME) with a single ext4 partition. I noticed that Amarok does NOT crash if I do the following: 1. Select all covers in cover manager by clicking some cover, then pressing Ctrl-A 2. Right-click some cover and select "Fetch Covers" 3. Quit Amarok So it only crashes when I fetch covers using the button "Fetch Missing Covers". "Fetch Missing Covers" probably opens one large task, where "Fetch Covers" opens many small tasks, I'm guessing. That's probably the difference. Thank you for the fast feedback. I still can't reproduce it here, somebody else maybe? I can reproduce it (the way Myriam described it in comment #1). And I get the same backtrace as Elez. I can reproduce it with Amarok 2.6 beta Git commit 2b20b48c7bb67e74c4d1d1a964b9d1006a5356bb by Ralf Engels. Committed on 09/08/2012 at 12:00. Pushed by rengels into branch 'master'. Fix crash when closing Amarok with running CoverFetcher childBarFinished was called with invalid m_progressDetailsWidget However also the m_progressMap needs protection. The CompoundProgressBar needs to be thread safe. Tests: Change is verified by me to fix the problem. REVIEW: 105942 FIXED-IN: 2.7 M +28 -0 src/statusbar/CompoundProgressBar.cpp M +2 -0 src/statusbar/CompoundProgressBar.h http://commits.kde.org/amarok/2b20b48c7bb67e74c4d1d1a964b9d1006a5356bb |