Summary: | Muon locks up when post-install script returns error | ||
---|---|---|---|
Product: | [Unmaintained] muon | Reporter: | Davor Cubranic <cubranic> |
Component: | qaptworker | Assignee: | Jonathan Thomas <echidnaman> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version First Reported In: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 1.2.95, 1.2.3 | |
Sentry Crash Report: |
Description
Davor Cubranic
2012-01-27 04:23:12 UTC
*** This bug has been marked as a duplicate of bug 292423 *** Jonathan, why do you think this is the same bug? 292423 does not mention anything about subprocess's error message. Oh, sorry. Knee-jerk at "locks up during update". Yeah, this is different. Git commit 490c2b529454d3175ab4b894a654d3941a37b690 by Jonathan Thomas. Committed on 27/01/2012 at 05:51. Pushed by jmthomas into branch '1.2'. Emit the CommitChangesFinished event even if dpkg fails. Otherwise frontends won't ever know that the commit finished, and will get stuck in commit mode forever (preventing exits) FIXED-IN:1.2.95, 1.2.3 M +1 -3 src/worker/worker.cpp http://commits.kde.org/libqapt/490c2b529454d3175ab4b894a654d3941a37b690 Git commit a3ac4eca5c05407cf59a317de6a12856db0a6f3c by Jonathan Thomas. Committed on 27/01/2012 at 05:51. Pushed by jmthomas into branch 'master'. Emit the CommitChangesFinished event even if dpkg fails. Otherwise frontends won't ever know that the commit finished, and will get stuck in commit mode forever (preventing exits) FIXED-IN:1.2.95, 1.2.3 M +1 -3 src/worker/worker.cpp http://commits.kde.org/libqapt/a3ac4eca5c05407cf59a317de6a12856db0a6f3c Thanks! That was some quick bugfix turnaround! Looking at the diff I couldn't tell, so could you please clarify: will Muon tell me which package's install failed? Yeah; during the commit, if a package fails it sends out an error to Muon (or any other frontend listening) about the error, and Muon saves it in a list. Once the commit is done Muon will re-initialize APT and display everything on the error and warning stacks that accumulated during the commit. The issue was that the QApt Worker never was sending out the commit finished signal, so it just hung there. ;-) That's great, thank you. Do you know if this is going to be in another 4.7.x bugfix release or not until 4.8 is out? Muon has its own release schedule independent of KDE's, but the fix will be included in both 1.3. and 1.2.3. |