| Summary: | Need a method to block contacts from within the text-ui | ||
|---|---|---|---|
| Product: | [Unmaintained] telepathy | Reporter: | David Edmundson <kde> |
| Component: | text-ui | Assignee: | Ahmed Ibrahim <ahmedibrahimkhali> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | ddomenichelli, mail |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | 0.4.0 | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | A patch that adds Block Contact button that bocks/unblock contact. | ||
|
Description
David Edmundson
2012-01-25 17:33:23 UTC
Assigning to R4md4c as he offered to implement this on IRC Created attachment 69845 [details]
A patch that adds Block Contact button that bocks/unblock contact.
I've added also signals/slots at the ChannelContactModel so that we can add ChatView logic and display the blocking/unblocking operation to the user.
This is not the proper place for patch reviews, but I'll mention two things I noticed: 1) setBlockEnabled() is a bit unintuitive the way it works. I would expect it to behave in the opposite way (i.e. setBlockEnabled(true) enables the "block contact" action and setBlockEnabled(false) enables the "unblock contact" action) 2) Watch your indentation. We use 4 spaces to indent. No tab characters. (In reply to comment #3) > This is not the proper place for patch reviews, but I'll mention two things > I noticed: > > 1) setBlockEnabled() is a bit unintuitive the way it works. I would expect > it to behave in the opposite way (i.e. setBlockEnabled(true) enables the > "block contact" action and setBlockEnabled(false) enables the "unblock > contact" action) > > 2) Watch your indentation. We use 4 spaces to indent. No tab characters. About posting a review request. I don't have KDE developer account to post one(I guess what is what I need to post a review request, right ?) . As for your notices. You are right I'll modify the code to meet your suggestions and to comply with the coding standard. Just go to https://identity.kde.org/ and register a new account. That should be enough to post new reviews... Git commit 70dca13386b104d877413f7f710119a0fd58aa20 by Martin Klapetek, on behalf of Ahmed Ibrahim. Committed on 31/03/2012 at 15:52. Pushed by mklapetek into branch 'master'. Block/Unblock feature in ktp-text-ui module REVIEW: 104407 M +52 -0 app/chat-window.cpp M +3 -0 app/chat-window.h M +1 -0 app/chatwindow.rc M +1 -0 app/main.cpp M +12 -0 lib/channel-contact-model.cpp M +2 -1 lib/channel-contact-model.h M +20 -0 lib/chat-widget.cpp M +5 -0 lib/chat-widget.h http://commits.kde.org/telepathy-text-ui/70dca13386b104d877413f7f710119a0fd58aa20 |