Bug 292366

Summary: konqueror doesnt show the HTML tools in Webkit mode
Product: [Applications] konqueror Reporter: Zé <mmodem00>
Component: generalAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: adawit
Priority: NOR    
Version: Git   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In: 4.8.1
Sentry Crash Report:

Description Zé 2012-01-25 01:15:26 UTC 
Version:           Git (using Devel) 
OS:                Linux

Konqueror doesnt show the HTML tools in Webkit mode.

Im refering to the tools available from the toolbar entry Tools-> HTML Configuration:
JavaScript
Java
Cookies
Plugins
Load Pictures
Activate Proxy
Activate Cache
Cache Policy -> ...

These entries should be available also when using Webkit view.

Also the Adblock entry does not appear and i still not sure if these features are correctly working when using Webkit view...

Reproducible: Always

Steps to Reproduce:
In webkit view these entries do not appear in Tool toolbar entry.

Actual Results:  
Already described

Expected Results:  
The entries that exist for the khtml view should also exist for the webkit view.

OS: Linux (x86_64) release 3.2.1-1.1-desktop
Compiler: gcc
Comment 1 Dawit Alemayehu 2012-01-25 17:07:46 UTC 
The so called "HTML Settings" item under the Tools menu is added by a Konqueror plugin called khtmlsettingsplugin. The plugin was designed prior to the existence of webkit and as such only supports khtml. 

Properly fixing this is more involved and requires adding a new extension to KPart in kdelibs. That is because the plugin itself needs access to properties of the browser engine itself and without the additions to KPart, the only way to get such access to the necessary properties is to directly link against the browser engine. That in turn means loading multiple browser engines each time the plugin gets loaded.

There is a very easy workaround if you do not mind both browser engines being loaded into memory at the same time. Simply copy "khtmlsettingsplugin.*" from "/usr/share/apps/khtml/kpartplugins/" to either "/usr/share/apps/kwebkitpart/kpartplugins/" or "~/.kde/share/apps/kwebkitpart/kpartplugins/".
Comment 2 Zé 2012-01-25 18:30:38 UTC 
Well the only one that could be more handy to me is the proxy entry, but when i click in it konqueror crashes.

These are features that really need to be created for webkit view.
Comment 3 Dawit Alemayehu 2012-03-01 23:27:37 UTC 
Git commit 63ad7a573c5bb2876375d4fbd02ed2078588b3d5 by Dawit Alemayehu.
Committed on 02/03/2012 at 00:21.
Pushed by adawit into branch 'KDE/4.8'.

Ported to the new KParts::HtmlSettingsInterface so it works with the webkit
engine too.
FIXED-IN: 4.8.1

M  +2    -2    konq-plugins/khtmlsettingsplugin/CMakeLists.txt
M  +31   -17   konq-plugins/khtmlsettingsplugin/settingsplugin.cpp

http://commits.kde.org/kde-baseapps/63ad7a573c5bb2876375d4fbd02ed2078588b3d5
Comment 4 Dawit Alemayehu 2012-03-01 23:29:15 UTC 
Git commit bbb50072c9f321bf516102e1a89672fe70cbc939 by Dawit Alemayehu.
Committed on 02/03/2012 at 00:21.
Pushed by adawit into branch 'master'.

Ported to the new KParts::HtmlSettingsInterface so it works with the webkit
engine too.
FIXED-IN: 4.8.1
(cherry picked from commit 63ad7a573c5bb2876375d4fbd02ed2078588b3d5)

M  +2    -2    konq-plugins/khtmlsettingsplugin/CMakeLists.txt
M  +31   -17   konq-plugins/khtmlsettingsplugin/settingsplugin.cpp

http://commits.kde.org/kde-baseapps/bbb50072c9f321bf516102e1a89672fe70cbc939