Bug 292266

Summary:	"kdesrc-build appears to be running" warning should be per-setup
Product:	[Developer tools] kdesrc-build	Reporter:	David Faure <faure>
Component:	general	Assignee:	Michael Pyne <mpyne>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	Git
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description David Faure 2012-01-23 11:46:56 UTC

Version:           git (using Devel) 
OS:                Linux

I have completely separated kdesrc-buildrc configurations, in different directories (for different versions of KDE).

Reproducible: Didn't try

Steps to Reproduce:
To do this, the rc file is not in my home, but in the toplevel of the kde sources, where I run the kdesrc-build script from (so basically, in the initial working directory of kdesrc-build).

Actual Results:  
Running kdesrc-build in two of these setups at the same time, gives the warning

 *** kdesrc-build appears to be running.  Do you want to:
  (Q)uit, (P)roceed anyways?: P


Expected Results:  
I don't think this warning makes sense, since the two instances of kdesrc-build run in separate directories, so they cannot interfer with each other. Different log directories, different sources, build dirs, and install dirs.

Could this warning only be shown when the same kdesrc-buildrc file is being used by two running kdesrc-build instances? i.e. make it "per setup", not global.

Thanks!

Comment 1 Michael Pyne 2012-01-23 23:55:29 UTC

Yes, that's probably the most valid behavior. I think this used to be a valid check for the .kdesvn-build-data but that is now stored in the same directory as the corresponding rc-file.

Really though the *most correct* thing would probably be to verify that individual source dirs/build dirs don't end up accidentally conflicting (e.g. because a user had duplicate rc files but didn't bother to disambiguate)... but then one could also argue that the perfect is the enemy of the good. ;)

Comment 2 Michael Pyne 2012-01-24 02:27:16 UTC

Git commit eaa354f99bb77f8a040558ce17612b70ccd1588b by Michael Pyne.
Committed on 24/01/2012 at 03:25.
Pushed by mpyne into branch 'master'.

Place lock file with associated rc file.

This should fix bug 292266 although I haven't tested that exact
operating mode. dfaure can just re-open if I was wrong though... ;)

M  +137  -131  kdesrc-build

http://commits.kde.org/kdesrc-build/eaa354f99bb77f8a040558ce17612b70ccd1588b