Bug 291972

Summary:	HEAD compiling issues under FreeBSD 8.2 [patch]
Product:	[Applications] digikam	Reporter:	Sulev-Madis Silber <bugs-kde-org033>
Component:	Portability-Compilation	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs-kde-org033, caulier.gilles
Priority:	NOR
Version:	2.6.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	FreeBSD
Latest Commit:	http://commits.kde.org/digikam/375daf5648caf2c1d95416db06dbf86ba6f37027	Version Fixed In:	4.3.0
Sentry Crash Report:
Attachments:	core.diff kipi-plugins.diff core_with_cmake.diff

Description Sulev-Madis Silber 2012-01-19 17:01:05 UTC

Version:           2.6.0 (using KDE 4.7.3) 
OS:                FreeBSD

I have few patches that fix issues compiling git HEAD under FreeBSD 8.2. I don't know if I implemented fix in "core" properly. I tried to make it perfect for "kipi-plugins"...

It also needs libkvm that I don't know how to properly add to cmake.


The other thing is that cmake doesn't detect "libkdcraw", "libkexiv2" and "libkipi" properly. I defined "DIGIKAMSC_USE_PRIVATE_KDEGRAPHICS" for workaround, worked. I know why (different name, ending with -kde4... different path, etc) and FreeBSD port has patches[1] for that. Not sure if those can be integrated to main distribution. There is one other interesting patch that port includes, although for old 1.9.0 version. I have no idea what's that good for.
I'm looking into port maintainership if noone responds :)


Sorry for two patches in one file, as there was no way to add TWO files (yes I was thinking about giving patches by URL).


1. http://www.freebsd.org/cgi/cvsweb.cgi/ports/graphics/digikam-kde4/files/
2. http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/graphics/digikam-kde4/files/patch-libs_3rdparty_cimg_CImg.h


Reproducible: Always

Steps to Reproduce:
Compile under FreeBSD 8.2


Expected Results:  
Get it compiled under FreeBSD 8.2

Comment 1 Sulev-Madis Silber 2012-01-19 17:03:57 UTC

Created attachment 68011 [details]
core.diff

Comment 2 Sulev-Madis Silber 2012-01-19 17:04:28 UTC

Created attachment 68012 [details]
kipi-plugins.diff

Comment 3 Sulev-Madis Silber 2012-01-19 17:05:59 UTC

Crap. I messed up report a little...

Comment 4 Sulev-Madis Silber 2012-01-21 19:19:47 UTC

Created attachment 68075 [details]
core_with_cmake.diff

Decided to hack CMake files too. Now compiles cleanly here.

Comment 5 caulier.gilles 2013-10-30 07:38:53 UTC

Can you update patches against current git/master please. I would include it for next 4.0.0 release. Thanks in advance

Note : i don't have any BSD system to check your patches. 

Thanks in advance

Gilles Caulier

Comment 6 caulier.gilles 2013-11-27 12:58:52 UTC

Sulev,

Do you see my previous message ?

Gilles Caulier

Comment 7 caulier.gilles 2014-08-29 15:32:12 UTC

Git commit 2ec47decfe744e017c3365c66d85acff05bef408 by Gilles Caulier.
Committed on 29/08/2014 at 15:31.
Pushed by cgilles into branch 'master'.

apply patch #68011 to support compilation under FreeBSD

M  +3    -0    libs/3rdparty/kmemoryinfo/kmemoryinfo_backend.cpp

http://commits.kde.org/digikam/2ec47decfe744e017c3365c66d85acff05bef408

Comment 8 caulier.gilles 2014-08-29 15:34:41 UTC

Git commit 7e71288afb4aaa3b11a05f48e945d718053385d3 by Gilles Caulier.
Committed on 29/08/2014 at 15:34.
Pushed by cgilles into branch 'master'.

apply patch #68012 to compile fine under FreeBSD

M  +7    -0    expoblending/manager/actionthread.cpp

http://commits.kde.org/kipi-plugins/7e71288afb4aaa3b11a05f48e945d718053385d3

Comment 9 caulier.gilles 2014-08-29 15:40:22 UTC

Git commit 375daf5648caf2c1d95416db06dbf86ba6f37027 by Gilles Caulier.
Committed on 29/08/2014 at 15:39.
Pushed by cgilles into branch 'master'.

apply patch #68075 to fix compilation under FreeBSD
FIXED-IN: 4.3.0

M  +4    -0    CMakeLists.txt
M  +3    -0    digikam/CMakeLists.txt
M  +3    -0    showfoto/CMakeLists.txt
M  +4    -1    tests/CMakeLists.txt

http://commits.kde.org/digikam/375daf5648caf2c1d95416db06dbf86ba6f37027