Bug 291711

Summary:	Redesign dialog for joining group chats
Product:	[Unmaintained] telepathy	Reporter:	Elias Probst <mail>
Component:	contactlist	Assignee:	Telepathy Bugs <kde-telepathy-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	d.cermak, flyser42, kde
Priority:	NOR
Version:	git-latest
Target Milestone:	Future
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Elias Probst 2012-01-16 22:24:44 UTC

Version:           git-latest (using Devel) 
OS:                Linux

Currently the dialog for joining group chats lacks several features.

- The name of the group chat needs to be entered every time (no completion list based on previous entered group chat names)

- There's no listing of available group chats on the server which provides the selected account (default limit to ~25 items as some servers may have thousands of group chats. A "Show more" button or an input field which starts listing a filtered list after entering 3 or more characters would be helpful for advanced queries of the list)

- It is not possible to query a specific server for its groupchats (one can also join a groupchat on a remote server like having an @googlemail.com account and joining groupchats on @conference.jabber.org).

- It is not possible keeping a list of favorite group chats. It probably makes sense to keep such a list in the group chat dialog. I can't imagine how group chats would fit into the contact list itself next to regular contacts. I have never used IRC via Telepathy, but maybe there's already something similar for favorite IRC rooms.

Reproducible: Always



Expected Results:  
See initial description

Comment 1 David Edmundson 2012-01-16 22:25:49 UTC

Worth looking at Empathy for inspiration (but not necessarily copying )

Comment 2 Elias Probst 2012-01-17 11:40:28 UTC

Also: I'd love to be able to auto-connect to selected group chats when going "Online"

Comment 3 Dominik Cermak 2012-01-25 21:14:02 UTC

Just a short note to avoid unnecessary work: I'm working on it.

Comment 4 Dominik Cermak 2012-01-31 11:20:18 UTC

Git commit 149412ffb8e5aac8a4deaebce57f5b33a1eb86fa by Dominik Cermak.
Committed on 31/01/2012 at 12:15.
Pushed by cermak into branch 'master'.

Add support for showing available rooms in join chat room dialog

This adds support for showing available rooms. You can query the default
server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are
there, the name and the description.
REVIEW: 103825

M  +1    -0    CMakeLists.txt
M  +145  -1    dialogs/join-chat-room-dialog.cpp
M  +16   -0    dialogs/join-chat-room-dialog.h
M  +87   -2    dialogs/join-chat-room-dialog.ui
A  +146  -0    rooms-model.cpp     [License: LGPL (v2.1+)]
A  +65   -0    rooms-model.h     [License: LGPL (v2.1+)]

http://commits.kde.org/telepathy-contact-list/149412ffb8e5aac8a4deaebce57f5b33a1eb86fa

Comment 5 Elias Probst 2012-01-31 13:28:37 UTC

The new dialog shows for an XMPP room with currently 7 participants a member count of 0.

Server:
OpenFire

Installed Telepathy packages:
KTP latest git (contact-list 149412ff)
dev-python/telepathy-python (0.15.19@07/30/2011):
net-im/kde-telepathy-meta (9999(4)[1]@01/30/2012):
net-im/telepathy-connection-managers (1@10/07/2011):
net-im/telepathy-logger (0.2.12@01/30/2012):
net-im/telepathy-mission-control (5.10.1@12/31/2011):
net-libs/telepathy-glib (0.16.3@12/30/2011):
net-libs/telepathy-qt (0.9.0@01/25/2012):
net-voip/telepathy-butterfly (0.5.15-r1@07/25/2011):
net-voip/telepathy-gabble (0.14.1@12/30/2011):
net-voip/telepathy-haze (0.5.0@12/06/2011):
net-voip/telepathy-salut (0.6.0@12/30/2011):
net-voip/telepathy-sofiasip (0.6.8@10/18/2011):

Comment 6 Dominik Cermak 2012-02-02 09:40:08 UTC

(In reply to comment #5)
> The new dialog shows for an XMPP room with currently 7 participants a member
> count of 0.
> 
> Server:
> OpenFire

As I just take the value telepathy reports I think it's either a bug in telepathy-qt/telepathy-gabble or the server doesn't report the member count (not sure if one could configure it).

Does any other client show the right value for this room?

Comment 7 Martin Klapetek 2012-02-23 12:38:02 UTC

Git commit aa94b03e763a8e8aabc771bbb2bc4ea58f835f2e by Martin Klapetek, on behalf of Dominik Cermak.
Committed on 31/01/2012 at 12:15.
Pushed by mklapetek into branch 'kde-telepathy-0.3'.

Add support for showing available rooms in join chat room dialog

This adds support for showing available rooms. You can query the default
server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are
there, the name and the description.
REVIEW: 103825

M  +1    -0    CMakeLists.txt
M  +145  -1    dialogs/join-chat-room-dialog.cpp
M  +16   -0    dialogs/join-chat-room-dialog.h
M  +87   -2    dialogs/join-chat-room-dialog.ui
A  +146  -0    rooms-model.cpp     [License: LGPL (v2.1+)]
A  +65   -0    rooms-model.h     [License: LGPL (v2.1+)]

http://commits.kde.org/telepathy-contact-list/aa94b03e763a8e8aabc771bbb2bc4ea58f835f2e

Comment 8 Dominik Cermak 2012-03-14 09:27:49 UTC

Git commit caa4e4e53b7074a15936f97730fc875033604f01 by Dominik Cermak.
Committed on 14/03/2012 at 10:17.
Pushed by cermak into branch 'master'.

Handle favorites in JoinChatroomDialog

Now one can maintain a list of favorite chatrooms.
Each account has it's own favorites.
REVIEW: 104173

M  +121  -5    dialogs/join-chat-room-dialog.cpp
M  +10   -0    dialogs/join-chat-room-dialog.h
M  +149  -70   dialogs/join-chat-room-dialog.ui
M  +95   -0    rooms-model.cpp
M  +55   -0    rooms-model.h

http://commits.kde.org/telepathy-contact-list/caa4e4e53b7074a15936f97730fc875033604f01

Comment 9 Dominik Cermak 2012-03-22 13:08:55 UTC

Git commit 2984af041b56accb484dba0bc89f741473c315aa by Dominik Cermak.
Committed on 22/03/2012 at 14:04.
Pushed by cermak into branch 'master'.

Maintain a list of recently used rooms in JoinChatroomDialog

Upon joining a room (more exact upon clicking "Ok") the room is saved in
the recently used list for this account.
ATM it remembers up to 8 rooms and single rooms can be removed as well
as the whole list can be cleared.

The complete list is shown in a new tab and the rooms are used for
completion in the lineEdit.
REVIEW: 104269

M  +125  -9    dialogs/join-chat-room-dialog.cpp
M  +8    -0    dialogs/join-chat-room-dialog.h
M  +47   -0    dialogs/join-chat-room-dialog.ui

http://commits.kde.org/telepathy-contact-list/2984af041b56accb484dba0bc89f741473c315aa

Comment 10 David Edmundson 2012-07-26 14:52:40 UTC

Closing. If anything still exists, open a new bug.

Make sure to only stick to one bug/request per report otherwise it's a nightmare to manage/close