Bug 291367

Summary:	When using some combination of font size and hinting, buttons don't give margin to accelerators
Product:	[Plasma] Oxygen	Reporter:	Jose <getaceres>
Component:	style	Assignee:	Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	andrew.crouthamel
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Default button size Big button size

Description Jose 2012-01-12 12:25:49 UTC

Version:           unspecified (using Devel) 
OS:                Linux

Hello, I'm using Ubuntu font with 11px, subpixel rendering and soft hinting (which is default in Ubuntu but not in Kubuntu) and the accelerator underscore takes part of the bottom border of buttons (due to them being of fixed size).

Reproducible: Didn't try

Steps to Reproduce:
Set Ubuntu font 11px, subpixel rendering and soft hinting.
Set accelerators to always shown in oxygen-settings.

Actual Results:  
The underscore in the text takes part of the bottom border of buttons.

Expected Results:  
To have some margin between the accelerator underscore and the button border.

Setting button size to a minimum of 30px in qtconfig leaves some room for the accelerator but I think that having variable buttons height based on text size is not an option :(

Comment 1 Jose 2012-01-12 12:26:21 UTC

Created attachment 67737 [details]
Default button size

Accelerators take part of the button border.

Comment 2 Jose 2012-01-12 12:28:12 UTC

Created attachment 67738 [details]
Big button size

There's some room for the accelerators (although every widget is bigger as well).

Comment 3 Andrew Crouthamel 2018-11-06 15:14:15 UTC

Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Jose 2018-11-08 09:33:43 UTC

I'm not using KDE4 anymore and my distribution only offers KDE5 right now so this bug is irrelevant now that 6 years have passed. You can close it unless someone on KDE4 wants to test it.

Comment 5 Andrew Crouthamel 2018-11-08 14:06:19 UTC

Thanks for the update!