Bug 291259

Summary:	Checking "Use system proxy configuration" does not enable "Apply" button
Product:	[Applications] systemsettings	Reporter:	Alvaro Manuel Recio Perez <amrecio>
Component:	kcm_proxy	Assignee:	Konqueror Developers <konq-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adawit, lueck
Priority:	NOR
Version:	1.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kde-baseapps/a52df46f43ecc3e5c893aaea7b981ec7c4ca4e46	Version Fixed In:	4.8.4
Sentry Crash Report:

Description Alvaro Manuel Recio Perez 2012-01-11 12:20:06 UTC

Version:           1.0 (using Devel) 
OS:                Linux

When the user selects the "Use system proxy configuration" option in the proxy configuration dialog the "Apply" button is not enabled, making difficult to save the chosen settings. This does not happen with the other options.

Reproducible: Always

Steps to Reproduce:
1. Open the proxy configuration dialog.
2. Check "Use system proxy configuration".

Actual Results:  
The "Apply" button is not enabled.

Expected Results:  
The "Apply" button is enabled to let the user save the configuration.

OS: Linux (x86_64) release 3.0.0-14-generic
Compiler: gcc
KDE 4.8.0 RC2
Kubuntu packages

Comment 1 Burkhard Lück 2012-01-12 07:51:19 UTC

Confirmed using master compiled from sources
$ systemsettings --version
xxQt: 4.8.0
KDE Development Platform: 4.7.97 (4.8 RC2 (4.7.97)
xxSystem Settingsxx: 1.0
xx

Comment 2 Dawit Alemayehu 2012-01-13 06:12:43 UTC

It is not supposed to be enabled unless you fill out at least one of the system proxy inputs with the proper environment variable or press the auto detect button so that it can attempt to guess and fill it out for you. 

For the record there is no such a thing called "system proxy" on Unix/Linux systems. It is there as convenience for using environment variables set on the system that might be shared with other apps, but the requirement is that you have to specify the name of the environment variable, e.g. HTTP_PROXY. 

I can confirm that the auto detect button does not get enabled and that is a bug, but that is not what you are reporting here. I will fix that issue right away. It is was a hind sight.

Comment 3 Dawit Alemayehu 2012-01-13 06:17:42 UTC

Git commit a52df46f43ecc3e5c893aaea7b981ec7c4ca4e46 by Dawit Alemayehu.
Committed on 13/01/2012 at 07:13.
Pushed by adawit into branch 'KDE/4.8'.

Make sure the "Auto Detect" button is enabled when the
"Use system proxy configuration" is selected.

Make sure users can simply click the Apply button after selecting the same
option under windows.

M  +2    -1    konqueror/settings/kio/kproxydlg.cpp
M  +0    -3    konqueror/settings/kio/kproxydlg.ui

http://commits.kde.org/kde-baseapps/a52df46f43ecc3e5c893aaea7b981ec7c4ca4e46

Comment 4 Dawit Alemayehu 2012-01-13 06:18:39 UTC

Git commit 5a31739e6ecb78bf444178f1512fc1fbe3c8dec3 by Dawit Alemayehu.
Committed on 13/01/2012 at 07:13.
Pushed by adawit into branch 'master'.

Make sure the "Auto Detect" button is enabled when the
"Use system proxy configuration" is selected.

Make sure users can simply click the Apply button after selecting the same
option under windows.
(cherry picked from commit a52df46f43ecc3e5c893aaea7b981ec7c4ca4e46)

M  +2    -1    konqueror/settings/kio/kproxydlg.cpp
M  +0    -3    konqueror/settings/kio/kproxydlg.ui

http://commits.kde.org/kde-baseapps/5a31739e6ecb78bf444178f1512fc1fbe3c8dec3