| Summary: | BQM Watermark tool : size original/unchanged/pixels/points | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | DrSlony <bugs> |
| Component: | Plugin-Bqm-WaterMark | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | ahmed.fathi.abdelmageed, bugs, caulier.gilles |
| Priority: | NOR | ||
| Version: | 4.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/f9121cd5122be78cb0171419b150634f9b215791 | Version Fixed In: | 5.5.0 |
| Attachments: |
absolute fonts and images
Photo To indicate current look |
||
|
Description
DrSlony
2012-01-10 03:01:21 UTC
Still valid in 4.2.0. Created attachment 103721 [details]
absolute fonts and images
I created a patch for this problem. now you have a new checkbox called "use absolute size". if you check the box , the size percentage slider is disabled for both image and text watermarks. furthermore , in the text mode , when you activate this checkbox , A column of font sizes to choose from gets enabled , otherwise it is disabled. Note : This patch assumes the user knows what he is doing. so if the user selects a font size so large that the water mark text typed is beyond the image boundaries , no automatic scaling is done. As it is assumed that if the user wants automatic scaling, he would have used the size slider instead
Sounds good. I don't compile my own digiKam so I won't be able to test until its released. Scaling should absolutely not be done if setting font size manually, otherwise it would be misleading. Why "a column of font sizes"? A spin box would be ideal. Created attachment 103722 [details]
Photo To indicate current look
It is to be said that I modified the way the user chooses text in another bugzilla entry to enable different font styles and the current configuration is just like the photo I am uploading here, just without the rightmost size column. So I thought a size column would be bette in this configuration . I thought adding this column is better looking than just a spin box or text box , as the (vertical) space is already occupied by the other two columns for font and style. What do you think ?
Ahmed, Do you add a tooltip to checkbox to explain to end user the option effect ? DrSlony, The other bugzilla entry that Ahmed said in comment #4 is bug #339460. Gilles Caulier @Ahmed that looks good. The "Size" column includes a spin button, so it's all good. @Caulier well I haven't been able to test this yet, but Ahmed's description sounds simple enough, so there's probably no need for a tooltip. Git commit f9121cd5122be78cb0171419b150634f9b215791 by Gilles Caulier. Committed on 31/01/2017 at 08:15. Pushed by cgilles into branch 'master'. apply patch #103721 from Ahmed Fathi to use absolute fonts with images. FIXED-IN: 5.5.0 M +2 -1 NEWS M +74 -35 utilities/queuemanager/tools/decorate/watermark.cpp M +2 -1 utilities/queuemanager/tools/decorate/watermark.h https://commits.kde.org/digikam/f9121cd5122be78cb0171419b150634f9b215791 DrSlony, I applied the patch. This evening, i will rebuild the AppImage 5.5.0 to test and available at usual place from GDrive repository. Gilles Caulier @Guilles It is a little late but I yes made a "what's this" discription for the checkbox for help @DrSlony yes it is all good thank you :) DrSlony, The new pre-version of 64 bits AppImage bundle 5.5.0 will be uploaded to GDrive in few minutes, including the last patch committed in this report. https://docs.google.com/document/d/1YOFkqIcoopQGZVWa3wioKz5Ue22Mi68dLYsG_YB2XSo/edit?usp=sharing You can test with it. Gilles Caulier Youps sorry wrong url. right one : https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM |