| Summary: | crash on moving a layer | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Halla Rempt <halla> |
| Component: | General | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | dimula73 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Halla Rempt
2012-01-05 16:31:37 UTC
Thanks, got it. My fault. Git commit 594e53058be70b4452e8b508418ffd687b31aad0 by Dmitry Kazakov. Committed on 06/01/2012 at 15:25. Pushed by dkazakov into branch 'master'. Temporary disable assert to allow people to work with master M +1 -1 krita/image/kis_image_signal_router.cpp http://commits.kde.org/calligra/594e53058be70b4452e8b508418ffd687b31aad0 Git commit 40b292a9dfc967571f14a4a673cf3489cd647157 by Dmitry Kazakov.
Committed on 08/01/2012 at 13:34.
Pushed by dkazakov into branch 'master'.
Finished porting KisShapeController to two-stage signals processing
Yay! Now it doesn't depend on multithreading of the KisImage at all!
The updates of the internal shapes representation are done in two stage
way like it is done for all the signals of KisCanvas2. First connection
is direct and fetches the data from the image and the second is automatic
and executed in the context of UI thread.
I introduced four new signals for the image:
void sigNodeAddedAsync(KisNodeSP node);
void sigNodeMovedAsync(KisNodeSP node);
void sigRemoveNodeAsync(KisNodeSP node);
void sigLayersChangedAsync();
They are supposed to supersede old 7 signals in the nearest future.
This is the biggest part of refactoring needed for closing bug 290708.
Now the only thing left is to port KisNodeModel to use dummies stored
inside KisShapesController.
M +4 -4 krita/image/kis_image.cc
M +8 -2 krita/image/kis_image.h
M +13 -4 krita/image/kis_image_signal_router.cpp
M +8 -2 krita/image/kis_image_signal_router.h
M +73 -81 krita/ui/flake/kis_shape_controller.cpp
M +14 -3 krita/ui/flake/kis_shape_controller.h
M +152 -85 krita/ui/tests/kis_shape_controller_test.cpp
M +23 -4 krita/ui/tests/kis_shape_controller_test.h
M +18 -6 krita/ui/tests/node_shapes_utils.h
http://commits.kde.org/calligra/40b292a9dfc967571f14a4a673cf3489cd647157
Git commit 6c8e7d9d17b4e1e0040e6c226781c5f148864265 by Dmitry Kazakov. Committed on 08/01/2012 at 14:16. Pushed by dkazakov into branch 'master'. Temporary crutch for bug 290708 to allow people to work with Move Tool Sometime the Undo of the Move tool crashes, because KisNodeModel is not ported yet. M +2 -1 krita/plugins/tools/defaulttools/kis_tool_move.cc http://commits.kde.org/calligra/6c8e7d9d17b4e1e0040e6c226781c5f148864265 Git commit dfc19c9649158820225318f9da7f1c5362b792d8 by Dmitry Kazakov. Committed on 03/02/2012 at 12:35. Pushed by dkazakov into branch 'shapes-as-node-model-kazakov'. Fixed managing selection masks which are children of the root node Now the mapping between KisNodeDummy and QModelIndex is done by classes KisModeIndexConverter and KisModelIndexConverterShowAll. They represent two options available to the user: normal mode and mode when the root layer is visible. This is the last commit in a series of refactorings for KisNodeModel. Now there should be no known crashes or bugs. So if you see one, do not hesitate to report! ;) My plan is the following: 1) I'm pushing it to my branch. 2) Then I'll fix drag-and-drop (it is unrelated to the refactorings) 3) Then I'll make a call for testing both of the features, to save the time of artists ;) Related: bug 291271 M +11 -3 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp M +28 -0 krita/sdk/tests/empty_nodes_test.h M +3 -0 krita/ui/CMakeLists.txt M +10 -3 krita/ui/flake/kis_dummies_facade_base.cpp M +2 -0 krita/ui/flake/kis_dummies_facade_base.h A +179 -0 krita/ui/kis_model_index_converter.cpp [License: GPL (v2+)] A +49 -0 krita/ui/kis_model_index_converter.h [License: GPL (v2+)] A +24 -0 krita/ui/kis_model_index_converter_base.cpp [License: GPL (v2+)] A +64 -0 krita/ui/kis_model_index_converter_base.h [License: GPL (v2+)] A +91 -0 krita/ui/kis_model_index_converter_show_all.cpp [License: GPL (v2+)] A +47 -0 krita/ui/kis_model_index_converter_show_all.h [License: GPL (v2+)] M +62 -86 krita/ui/kis_node_model.cpp M +4 -3 krita/ui/kis_node_model.h M +6 -0 krita/ui/tests/CMakeLists.txt A +279 -0 krita/ui/tests/kis_model_index_converter_test.cpp [License: GPL (v2+)] A +61 -0 krita/ui/tests/kis_model_index_converter_test.h [License: GPL (v2+)] http://commits.kde.org/calligra/dfc19c9649158820225318f9da7f1c5362b792d8 |