| Summary: | KMail crashes when editing IMAP ACL | ||
|---|---|---|---|
| Product: | [Applications] kmail2 | Reporter: | Thiago Macieira <thiago> |
| Component: | config dialog | Assignee: | kdepim bugs <pim-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | montel |
| Priority: | NOR | ||
| Version First Reported In: | 4.8 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Thiago Macieira
2012-01-01 18:04:45 UTC
Can't reproduce it.
But code is:
void AclEntryDialog::setPermissions( KIMAP::Acl::Rights permissions )
{
QAbstractButton* button = d->mButtonGroup->button( KIMAP::Acl::normalizedRights( permissions ) );
if ( button ) {
button->setChecked( true );
} else {
QRadioButton *radioButton = new QRadioButton( AclUtils::permissionsToUserString( permissions ) );
d->mButtonLayout->addWidget( radioButton );
d->mButtonGroup->addButton( radioButton, permissions );
}
d->mCustomPermissions = permissions;
}
I don't understand why it crashs because we add just an radiobutton
ok found: mButtonLayout is never defined. => it will crash normal d->mButtonLayout->addWidget( radioButton ); Git commit 1888e8580d2e8ef32911318652edc8610463d438 by Montel Laurent. Committed on 12/01/2012 at 19:38. Pushed by mlaurent into branch 'master'. Fix Bug 290341 - KMail crashes when editing IMAP ACL CCMAIL: thiago@kde.org I can't reproduce crash but Thiago could you test it please ? easy to backport and report me if it fix it. Thanks Regards M +4 -4 mailcommon/aclentrydialog.cpp http://commits.kde.org/kdepim/1888e8580d2e8ef32911318652edc8610463d438 Git commit a4cd27dea47b7b34973a52d7f4e0f86ef0574345 by Montel Laurent. Committed on 12/01/2012 at 19:38. Pushed by mlaurent into branch 'KDE/4.8'. Fix Bug 290341 - KMail crashes when editing IMAP ACL CCMAIL: thiago@kde.org I can't reproduce crash but Thiago could you test it please ? easy to backport and report me if it fix it. Thanks Regards (cherry picked from commit 1888e8580d2e8ef32911318652edc8610463d438) M +4 -4 mailcommon/aclentrydialog.cpp http://commits.kde.org/kdepim/a4cd27dea47b7b34973a52d7f4e0f86ef0574345 Fix confirmed. |