| Summary: | PATCH: Improvements for Levels adjust tool | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Matthias Welwarsky <matze> |
| Component: | Plugin-Editor-Levels | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 2.5.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 2.5.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Patch implementing the described improvement
Updated patch |
||
Created attachment 67258 [details]
Updated patch
Updated patch, removing the change to adjustlevelstool.h, which is superfluous.
Matthias, I tested your patch and it work fine for me. Let's go to commit your patch in git /master... Gilles Caulier Git commit 654ad777755c8e70c5702a257f26b7d602109e8f by Gilles Caulier. Committed on 31/12/2011 at 14:56. Pushed by cgilles into branch 'master'. polish patch for Matthias Welwarsky and close relevant file in bugzilla M +45 -38 imageplugins/color/adjustlevelstool.cpp M +1 -1 imageplugins/color/adjustlevelstool.h http://commits.kde.org/digikam/654ad777755c8e70c5702a257f26b7d602109e8f |
Created attachment 67257 [details] Patch implementing the described improvement Version: unspecified (using KDE 4.7.3) OS: Linux Enable Color Channels histogram type in Levels tool This patch enables the "Color Channels" histogram type in the Levels tool. It is helpful when adjusting luminosity to observe if any of the color channels clip, which leads to false highlight colors. The patch also implements a second function: if Color Channels is selected, Black and White tone pickers work on all of the color channels simultaneously instead of having to iterate over R, G and B. It is very helpful for removing the color mask of a scanned film negative. Reproducible: Didn't try Expected Results: Vastly improved functionality of Levels adjustment tool after applying the patch :-) The patch applies to the master branch of digigkam-sc core.git. It was created with "git format-patch" and can simply be applied with "git am 0001-Enable-Color-Channels-histogram-type-in-Levels-tool.patch"