Bug 289871

Summary: KShortcutsEditor shows actions without global shortcuts when KShortcutsEditor::GlobalAction is specified.
Product: [Unmaintained] kdelibs Reporter: Jekyll Wu <adaptee>
Component: kdeuiAssignee: kdelibs bugs <kdelibs-bugs-null>
Status: RESOLVED UNMAINTAINED    
Severity: normal CC: cfeck
Priority: NOR    
Version First Reported In: 4.8   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: configuring shortcuts of klipper

Description Jekyll Wu 2011-12-26 16:29:32 UTC
Created attachment 67135 [details]
configuring shortcuts of klipper

Version:           Git (using Devel) 
OS:                Linux

I noticed this issue when reading the code of klipper. Here is the relateed code:

    // kde-workspace/klipper/configgdialog.cpp:274
    QWidget* w = new QWidget(this);
    m_shortcutsWidget = new KShortcutsEditor( collection, w, KShortcutsEditor::GlobalAction );

But in the attached screenshot, those actions without global shortcuts are also shown. It is not only ugly, but also confusing to the users: Why can't I edit those actions since they are listed here?


Reproducible: Always

Steps to Reproduce:
Open the configuration dialog of klipper, then goto the 'Shortcuts' page

Actual Results:  
'Quit' and 'Show barcode'  are listed there

Expected Results:  
'Quit' and 'Show barcode'  are not listed there
Comment 1 Christoph Feck 2012-01-05 19:49:53 UTC
What do you suggest:

1) They should not be listed
2) They should be editable

I mean, in this case it would be quite stupid to be able to assign a global shortcut for the "Quit" action, but on the other hand, only being able to edit global shortcuts for the cases where the developer had originally set a default value could be limiting.
Comment 2 Jekyll Wu 2012-01-05 20:22:20 UTC
(In reply to comment #1)

I would suggest "not being listed", at least that is what I have expected after reading that line of code in Klipper and the documentation of class KShortcutsEditor.

If for some reason the current behavior won't be fixed, I think at least the documentation should mention this unexpected behavior in a clear way.
Comment 3 Christoph Cullmann 2024-09-14 17:07:03 UTC
Hi,

kdelibs (version 4 and earlier) is no longer maintained since a few years.

KDE Frameworks 5 or 6 might already have resolved this bug.

If not, please re-open against the matching framework if feasible or against the application that shows the issue.

We then can still dispatch it to the right Bugzilla product or component.

Greetings
Christoph Cullmann