Bug 289777

Summary: [PATCH] kded_keyboard fails to build (final): redefinition of "const char* LIST_SEPARATOR"
Product: [Applications] systemsettings Reporter: esigra
Component: kcm_keyboardAssignee: Andriy Rysin <arysin>
Status: RESOLVED FIXED    
Severity: normal CC: adaptee, esigra
Priority: NOR Keywords: reproducible
Version: 4.9.4   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: patch that fixes the build

Description esigra 2011-12-25 11:51:59 UTC
Created attachment 67094 [details]
patch that fixes the build

Version:           unspecified (using KDE 4.7.3) 
OS:                Linux

kcm_keyboard fails to build with KDE4_ENABLE_FINAL=ON becasue LIST_SEPARATOR is defined in several places.

Reproducible: Always

Steps to Reproduce:
1. tar jxvf /usr/portage/distfiles/kde-workspace-4.7.3.tar.bz2
2. cd kde-workspace-4.7.3
3. mkdir build
4. cd build
5. cmake -DKDE4_ENABLE_FINAL=ON ..
6. make kded_keyboard

Actual Results:  
In file included from /home/work/programmering/kde-workspace-4.7.3/build/kcontrol/keyboard/kded_keyboard_final_cpp.cpp:8:0:                                                                                 
/home/work/programmering/kde-workspace-4.7.3/kcontrol/keyboard/keyboard_config.cpp:27:20: error: redefinition of 'const char* LIST_SEPARATOR'
/home/work/programmering/kde-workspace-4.7.3/kcontrol/keyboard/layout_memory_persister.cpp:44:20: error: 'const char* LIST_SEPARATOR' previously defined here

Expected Results:  
successful build
Comment 1 Andriy Rysin 2013-02-07 03:50:23 UTC
I've pushed a fix for this in 4.10.1: 22e0d313a304beb5916da85c8daa96cb105a78bd 
Unfortunately misspelled BUG tag so I'll close it manually.