Bug 289754

Summary:	kdesrc-build should flag module as unbuilt if last build for that module was interrupted
Product:	[Developer tools] kdesrc-build	Reporter:	Michael Pyne <mpyne>
Component:	general	Assignee:	Michael Pyne <mpyne>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	Git
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:	https://invent.kde.org/sdk/kdesrc-build/commit/8f80fdf17cb5c49b9993f5a0bf395402daab5d8e	Version Fixed In:
Sentry Crash Report:

Description Michael Pyne 2011-12-24 18:11:44 UTC

Right now, if you interrupt a module build and then immediately run kdesrc-build on that module again, (assuming no change in source code) then kdesrc-build will skip building that module as it assumes it was fully built the last time.

We should instead store a flag before building the module that it is undergoing the build process and not clear that flag until the module successfully builds, so that the persistent data will be correct when stored to disk.

Comment 1 Justin Zobel 2021-03-09 23:42:29 UTC

Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.

Comment 2 Michael Pyne 2022-06-24 02:44:50 UTC

Git commit 8f80fdf17cb5c49b9993f5a0bf395402daab5d8e by Michael Pyne.
Committed on 24/06/2022 at 02:40.
Pushed by mpyne into branch 'master'.

build: Ensure a rebuild following an interrupted build is attempted.

Previously, interrupting a module build during the build was not treated
as a build failure, so the module's persistent options were not changed.
In the normal scenario this means the module's last build was remembered
as a success. Then by default, when you'd go to rebuild the module right
after, the build would be skipped because the source didn't change.

M  +10   -3    modules/ksb/Application.pm

https://invent.kde.org/sdk/kdesrc-build/commit/8f80fdf17cb5c49b9993f5a0bf395402daab5d8e