Summary: | Alt+Left-click on a maximized window immediately restores it to smaller size | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Syam <get.sonic> |
Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | cfeck, nx.devnull, oliver.henshaw, pascal |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/kde-workspace/aa5e49e25fb803b42d60147d409404f017854764 | Version Fixed In: | 4.11 |
Sentry Crash Report: | |||
Attachments: |
work in progress patch
work in progress patch Work in progress patch |
Description
Syam
2011-12-21 12:13:32 UTC
At the moment I would call it the correct behavior and not a bug. Nevertheless I agree that this is not optimal, so I change to wishlist and will try to have a look at it. A possible implementation would affect the movement of all windows when alt+click is used. It is questionable whether an instant move is expected and the drag distance is not needed. *** Bug 222100 has been marked as a duplicate of this bug. *** The best solution would be to require a certain threshold to be passed before the window is unmaximized. I did manage to hack kwin to require the mouse y position to be greater than 48 before unmaximizing (this doesn't fix this bug, but it does fix bug 222100, and it probably wouldn't be hard to change this to an offset threshold), but the window does not restore correctly. It restores and then immediately resizes to the maximized size. I'll try to figure out why, but I'll attach the work in progress patch in case someone wants to check it out. Created attachment 74045 [details]
work in progress patch
Created attachment 74046 [details]
work in progress patch
Previous patch was in wrong format
Patch is against KDE 4.9.1
Created attachment 74047 [details]
Work in progress patch
and that one was reversed... sorry
please don't attach patches (they will just get lost herre, promised), but make a review request on git.reviewboard.kde.org Sorry for the wait, review request is live: https://git.reviewboard.kde.org/r/106796/ Git commit aa5e49e25fb803b42d60147d409404f017854764 by Thomas Lübking. Committed on 14/03/2013 at 21:54. Pushed by luebking into branch 'master'. block quick tiling unless actually moved REVIEW: 109485 FIXED-IN: 4.11 M +13 -2 kwin/events.cpp M +14 -25 kwin/geometry.cpp http://commits.kde.org/kde-workspace/aa5e49e25fb803b42d60147d409404f017854764 KDE 4.11 works great with Chrome, no more annoying unmaximizations. Thanks! |