Summary: | Crash while editing | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | Aleix Pol <aleixpol> |
Component: | folding | Assignee: | kdevelop-bugs-null |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | aleixpol |
Priority: | VHI | ||
Version: | 0.2 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
New crash information added by DrKonqi
Crashy file |
Description
Aleix Pol
2011-12-20 23:33:53 UTC
It always happens when I uncomment using Ctrl+Shift+D. It's been fixed in kate already. I was pretty sure I reported it there... -.- Created attachment 68018 [details]
New crash information added by DrKonqi
kdevelop (4.3.60) on KDE Platform 4.7.98 (4.8 RC2+ (4.7.98) using Qt 4.8.0
Still... uncomment with ctrl+shift+D... bam!
-- Backtrace (Reduced):
#13 0xb63e9945 in qt_assert(char const*, char const*, int) () from /usr/lib/libQtCore.so.4
#14 0xb08f86bc in KateCodeFoldingTree::findNodeAt (this=0xf5e5dd8, position=...) at /home/kde-devel/src/kate/part/syntax/katecodefolding.cpp:746
#15 0xb08f8929 in KateCodeFoldingTree::findNodeForPosition (this=0xf5e5dd8, l=176, c=20) at /home/kde-devel/src/kate/part/syntax/katecodefolding.cpp:799
#16 0xb08776ed in KateDocument::comment (this=0xfae3f78, v=0xd335e38, line=176, column=20, change=-1) at /home/kde-devel/src/kate/part/document/katedocument.cpp:3410
#17 0xb09103d7 in KateView::uncomment (this=0xd335e38) at /home/kde-devel/src/kate/part/view/kateview.cpp:2259
aleix, do you have a file where this is reproducible? if so, please show it to me and I'll try to fix this mess. it's just like I feared - let someone write code in GSOC without unit tests == fix the stuff yourself afterwards :-( Created attachment 68024 [details]
Crashy file
uncomment inside ::allRunners to reproduce the crash. could reproduce Git commit 12b967abdd9f546e02f474e20139b7e78aefb033 by Milian Wolff. Committed on 19/01/2012 at 23:23. Pushed by mwolff into branch 'master'. fix assertion when trying to uncomment lines without comment M +3 -1 part/syntax/katecodefolding.cpp M +22 -0 part/tests/katefolding_test.cpp M +1 -0 part/tests/katefolding_test.h http://commits.kde.org/kate/12b967abdd9f546e02f474e20139b7e78aefb033 Git commit d978e5b276644f5378f95215d0c7ad52107770cb by Milian Wolff. Committed on 19/01/2012 at 23:23. Pushed by mwolff into branch 'KDE/4.8'. backport from master: fix assertion when trying to uncomment lines without comment cherry-pick of commit 12b967abdd9f546e02f474e20139b7e78aefb033 M +3 -1 part/syntax/katecodefolding.cpp M +22 -0 part/tests/katefolding_test.cpp M +1 -0 part/tests/katefolding_test.h http://commits.kde.org/kate/d978e5b276644f5378f95215d0c7ad52107770cb |