Bug 289187

Summary: edge detection/sobel filters are broken
Product: [Applications] krita Reporter: Halla Rempt <halla>
Component: FiltersAssignee: Sahil <nagpal.sahil01>
Status: RESOLVED FIXED    
Severity: normal CC: cberger, nagpal.sahil01, virat.sardana2012
Priority: NOR Keywords: junior-jobs
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:

Description Halla Rempt 2011-12-17 12:02:31 UTC
Long-standing bug. We might need to disable these filters for 2.4
Comment 1 Cyrille Berger 2012-01-03 10:54:18 UTC
Git commit 2a8415ae0456d8b11e76928c89df9725f0ca22ed by Cyrille Berger.
Committed on 03/01/2012 at 11:51.
Pushed by berger into branch 'master'.

Fix: emboss and edge detection filters
Related: bug 289188

M  +0    -3    krita/plugins/filters/convolutionfilters/kis_convolution_filter.cpp

http://commits.kde.org/calligra/2a8415ae0456d8b11e76928c89df9725f0ca22ed
Comment 2 Cyrille Berger 2012-01-03 10:56:45 UTC
Sobel does work for me, to some extent. Except that when I do on 1600x1200 8bit image:
* draw something
* select the sobel filter, and check all boxes
* click ok, then I get sometime, some transparents bands in the image
* undo
* select filter > apply filter again
* then I get the correct result

Not sure if it is really the sobel filter's fault though
Comment 3 Halla Rempt 2012-02-29 14:32:47 UTC
The preview doesn't work correctly for me: it makes half the image transparent... Can anybody else confirm? For the rest, sobel seems to work when applied now.
Comment 4 Halla Rempt 2013-07-30 12:53:46 UTC
By default "opaque" is unchecked and it should be checked -- apart from that, the filter seems to work fine now.

As for the edge detection filters, check with the gimp's edge detection filters. Ours make the image transparent, and that's wrong.
Comment 5 Halla Rempt 2013-09-25 14:54:13 UTC
This was fixed by Sahil