Bug 289163

Summary: Display brightness change not saved
Product: [Unmaintained] solid Reporter: Amos Kariuki <amoskahiga>
Component: powermanagement-kcmAssignee: Dario Freddi <drf>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Proposed patch

Description Amos Kariuki 2011-12-17 07:03:51 UTC 
Version:           unspecified (using KDE 4.7.3) 
OS:                Linux

If a profiles "Display Brightness" slider value is adjusted using the mouse's scroll-wheel, the slider visually advances but the value is not saved when the dialog is closed.

Reproducible: Always

Steps to Reproduce:
1. Open the "Power Profiles" KDE Control Module.
2. Change the "Display Brightness" slider's position by either:
a. clicking on an empty location on the slider (do not click or drag the slider's button), or
b. By using the mouse's scroll-whee, or
c. By using the keyboard arrow keys.

3. Save and close the dialog by clicking the dialog's Apply/OK button.
4. Reopen the "Power Profiles" dialog.

Actual Results:  
When the "Power Profiles" is reopened, the "Display Brightness" slider will be set to the original position (before the last change)

Expected Results:  
The slider's position should be updated to the last set position.

The slider's value is not being updated.

I've attached a possible (untested) patch.
Comment 1 Amos Kariuki 2011-12-17 07:06:01 UTC 
Created attachment 66824 [details]
Proposed patch
Comment 2 Dario Freddi 2011-12-17 12:45:35 UTC 
Git commit 57307a33f3cd6872c9f136e47b13336560f2ab5c by Dario Freddi.
Committed on 17/12/2011 at 13:44.
Pushed by dafre into branch 'KDE/4.7'.

The slider should react whenever the value changes, and not just on move.

Thanks Amos Kariuki for suggesting the fix

BUG:289163

M  +1    -1    powerdevil/daemon/actions/bundled/brightnesscontrolconfig.cpp

http://commits.kde.org/kde-workspace/57307a33f3cd6872c9f136e47b13336560f2ab5c
Comment 3 Dario Freddi 2011-12-17 12:47:01 UTC 
Git commit bf7c60e9816b861857f0976b5f8d9100408e35d8 by Dario Freddi.
Committed on 17/12/2011 at 13:44.
Pushed by dafre into branch 'master'.

The slider should react whenever the value changes, and not just on move.

Thanks Amos Kariuki for suggesting the fix

BUG:289163
(cherry picked from commit 57307a33f3cd6872c9f136e47b13336560f2ab5c)

M  +1    -1    powerdevil/daemon/actions/bundled/brightnesscontrolconfig.cpp

http://commits.kde.org/kde-workspace/bf7c60e9816b861857f0976b5f8d9100408e35d8