| Summary: | Add option for disabling "expandable folders" | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Zé <mmodem00> |
| Component: | view-engine: details mode | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | adjam7, alpeterson, cris2007, cyberbeat, elandread, kairo, m.wege, msdobrescu, nitro, thomas |
| Priority: | NOR | ||
| Version: | 1.99 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8.2 | |
| Sentry Crash Report: | |||
| Attachments: |
patch to disable expansion in main-details-view
Patch with gui option |
||
|
Description
Zé
2011-12-16 03:48:18 UTC
*** Bug 289089 has been marked as a duplicate of this bug. *** *** Bug 289089 has been marked as a duplicate of this bug. *** This is not just a wishlist, it is a functional and accessibility issue, I need to be able to have a folder view with just the items in the one folder showing. This should be details view.. Expando view should be a new view option, as it is new behavior. (I also only use details view, and have double clicks to prevent accidental activation) As Dolphin still has the bug where multiple items get selected with single clicks, this compounds the danger. Someone with poor motor control will do unintended actions.. As cool as this expandable folder feature is, I rarely expect to need it, and I would like to turn it off. I do not intend to move files from multiple folders in one action to other folders. all I can think of is some way to limit selection to one folder at a time, and this gets complicated. How does this work with hard links between files in different folders? Also, this makes undoing harder. *** Bug 290724 has been marked as a duplicate of this bug. *** would propose having a tree view and a details view again, as tree view may be useful to others. I need that option back, too. Will you reimplement that? And if so, can you give some kde-version to plan with? Perhaps I could help with this. btw all other issues I had with dolphin-rc2 seem to be fixed in 4.8-head, thanks for that. another thing to mention for other people, which can not live with some regressions: seems to me like dolphin from kde-4.7 branch compiles fine against kde-4.8 branch and also runs without problems so far. Created attachment 67931 [details]
patch to disable expansion in main-details-view
I think it is possible to build uppon this patch, to re-add an option for expansion in detail-view.
I am proud, that I managed disabling expansion while keeping folder-view working :-)
Great work H.H. :) I think this patch can be shiped. oh no, this patch is a workaround, the option in the gui is missing. with my patch tree-view is impossible. Created attachment 68066 [details]
Patch with gui option
I succeeded to re-add the gui option. Only problem: I failed in getting that option applied on "apply". It is only applied on startup.
@Peter Penz: Is my patch done the right way? Could you help me for the remaining issue (after kde-4.8 release stress)?
@H.H.: I'm really happy about any support I can get for Dolphin and I want to say thanks for your efforts. But I think it would have been better to wait for an answer before investigating so much work into this: I've removed this option on purpose and I wanted to readd it again only if there are a high number of complaints which might indicate that my decision was wrong (... and yes: I'm aware that anybody that is subscribed to this bug is convinced that my decision is wrong ;-)). Without going into too much implementation details: The patch with the UI option is not sufficient for a fully working version of this option. The drag & drop behavior must be adjusted too when "open folders during drag operation" is activated and there are other subtle differences that make the maintenance tricky... So I'd really like to wait for the user feedback after 4.8 is out before deciding to readd this option again. We anyhow may not add this feature for 4.8.x due to the new UI strings... I'm happy to use your patch as base then, but I cannot promise currently that this option will be added again. Can you explain the problem with drag&drop behaviour, and more details about the other things? I am willing to fix all problems, if you give me some hints. I did not have problems with my patch so far. Even, if you won't adapt the feature again, I will maintain my patch, because I am sure, I'll never get used to the tree view on the right, that's what the folderview is for.. Thanks for this great offer, but I'd suggest lets wait on the feedback first after 4.8 is out. I don't want to create any workload for you where I probably might not add the code into Dolphin ;-). I'm really open to change my opinion for this option: I wanted to use Dolphin 2.0 also as a chance to get rid of some codepaths for options that are (probably?) never or very rarely used (each codepath of course consumes time and workload for maintaining it). To me the current number of duplicates for this bug already indicates that after 4.8 the chances for more duplicates are high, so that my decision to remove this option was wrong. So lets wait a few weeks - afterwards it would be great if we could work together on this :-) I still havent a chance to test the last patch update since i prefer to have dolphin respecting the theme definitions and not have expandable folders in right panel, so im forced to go back to SHA 37247c00868a1ee2a84bf7b463cc92b16579f813 that dates from 30/07/2011. Anyway i get Peter point, but even if there wasnt a much revelant feedback against having expandable folders, the most reasonable choice would be to always give the user the ability to choose, thus providing an option to enable/disable that feature. @Peter, KDE is used by so many people. If this option gets removed from 4.8, so many distros will be unusable... they won't patch it. We should have a UI experimentation branch of KDE, and I would gladly play with that... I wish we didn't play with release software. Think of ubuntu Unity... That is a horrible steaming pile of slop... they have some cool ideas, but nobody can stand using it by default. And with KDE doing similar things to what users are used to, we all are switching to xfce and other window managers. We should have very very few complaints as our threshold for using software. Multiple options are great... yes more code paths yes, but if managed properly we can all be happy. Those of use who do lots of file wrangling will be forced to use another manager, and you won't hear about it. I beg you to put it back in for 4.8 so the distros that use it are usable out of the box. New features can run a cycle as an option, be default in the UI experimentation branch, and maybe switch to being default. How much money would it take to get the details view back? I value KDE enough that I will throw some money in. ( I am unemployed, so am trying to help with bugs and testing) Also, please remember, that very few people use 4.8 beta... So if it goes mainstream, you will probably get a lot of requests. Peter, Thank you for your work, and we want to support you. Let us know what we can do. @all: Thanks for your feedback. 16 comments (although KDE apps 4.8.0 is not even released) show me that my decision was wrong and I'll readd the option again. I'll also backport this to 4.8.x but in 4.8.x you'll need to manually adjust the dolphinrc file to disable the expansion-toggle because no new user interface strings are allowed for the 4.8.x branch. I'll provide a detailed description here as soon as the patch has been merged. H.H. could you please attach the patch? At least i would start packaging dolphin providing to the end user the ability to choose and not force him to just use some option i would like more. *** Bug 292760 has been marked as a duplicate of this bug. *** H.H. could you please update the patch? With latest changes in kde-baseapps from git master is no longer possible to apply the patch. Im really failing to understand why Peter does not allow the user to not use expandable folders, this isnt making any sense... He could even set to use expandable folder in detail view by default, but at least allow the user to have the choice to use it or not, like it used to happen untill dolphin 2.0. (In reply to comment #21) > Im really failing to understand why Peter does not allow the user to not use > expandable folders, this isnt making any sense... > > He could even set to use expandable folder in detail view by default, but at > least allow the user to have the choice to use it or not, like it used to > happen untill dolphin 2.0. Because it would involve an 'if' somewhere in the code, that could be very expensive and he consumed all of them in other important tasks...Just kidding. Now, seriously, please, do not remove the customization, it is useful to us. @Ze + Mihai: Is it really too much to read + understand the previous comments (see comment 17)? To state it again: I'll readd this option! But honestly: my motivation doing it really goes against 0 now... @Peter Penz : oh no, don't loose your motivation. I really look forward all the time for the re-addition :-) I am really thankfull, that you care (and always did) about user-reports like this. @Ze: Why do you have to use dolphin trunk? (In reply to comment #23) > @Ze + Mihai: Is it really too much to read + understand the previous comments > (see comment 17)? To state it again: I'll readd this option! But honestly: my > motivation doing it really goes against 0 now... Oh, please forgive my programmer humor. I am grateful for all of your work too. I'm so sad to hear that your motivation tends to 0. As software developer, I have thid mood too sometimes... (In reply to comment #24) > @Peter Penz : oh no, don't loose your motivation. I really look forward all the > time for the re-addition :-) I am really thankfull, that you care (and always > did) about user-reports like this. > > @Ze: Why do you have to use dolphin trunk? Is Mr. Zé that Mandriva maintainer? Peter i didnt understand that way, i thought you were to simply drop it, so sorry for my last comment. Im using kde branch, thatys why. But now i have put dolphin back to the SHA previous to 2.0 development. I would also like to have this feature back. I miss it very much. But in the old implementation there was one thing not working good. It was not possible to draganddrop upward a folder path. Meaning. I could not go up in the folder hierachy with files marked and ready for droping. I would suggest that a reimplemenation of this feature should also take care of this. My suggestion was/is to have in this mode a virtual folder ".." like other filemanagers have. It does not have to be "..", but a virtual folder with this function. Git commit e04cb14b19e05282f58d5d39d790b3c334366172 by Peter Penz. Committed on 09/03/2012 at 16:12. Pushed by ppenz into branch 'KDE/4.8'. Details view: Allow to turn off expandable folders like in Dolphin 1.7 The option for turning off expandable folders has been removed with the new view-engine. Due to several requests this option has been readded again. As for 4.8.x no new user-interface strings may be introduced, the line ExpandableFolders=false must be manually added below the section "[DetailsMode]" in the file ~/.kde/share/config/dolphinrc if the expandable-folders feature should be disabled. Thanks to H.H. "cyberbeat" for the initial patch! FIXED-IN: 4.8.2 M +10 -3 dolphin/src/kitemviews/kfileitemlistview.cpp M +1 -0 dolphin/src/kitemviews/kfileitemlistview.h M +25 -5 dolphin/src/kitemviews/kfileitemlistwidget.cpp M +4 -0 dolphin/src/kitemviews/kfileitemlistwidget.h M +14 -8 dolphin/src/kitemviews/kitemlistview.cpp M +9 -15 dolphin/src/kitemviews/kitemlistview.h M +4 -0 dolphin/src/settings/dolphin_detailsmodesettings.kcfg M +42 -5 dolphin/src/settings/viewmodes/viewsettingstab.cpp M +2 -0 dolphin/src/settings/viewmodes/viewsettingstab.h M +8 -0 dolphin/src/views/dolphinitemlistcontainer.cpp http://commits.kde.org/kde-baseapps/e04cb14b19e05282f58d5d39d790b3c334366172 Git commit 4763cb6235a66f4eba5ed436a99bd3dd07a2acc8 by Peter Penz. Committed on 09/03/2012 at 16:12. Pushed by ppenz into branch 'master'. Details view: Allow to turn off expandable folders like in Dolphin 1.7 The option for turning off expandable folders has been removed with the new view-engine. Due to several requests this option has been readded again. As for 4.8.x no new user-interface strings may be introduced, the line ExpandableFolders=false must be manually added below the section "[DetailsMode]" in the file ~/.kde/share/config/dolphinrc if the expandable-folders feature should be disabled. Thanks to H.H. "cyberbeat" for the initial patch! FIXED-IN: 4.8.2 M +10 -3 dolphin/src/kitemviews/kfileitemlistview.cpp M +1 -0 dolphin/src/kitemviews/kfileitemlistview.h M +25 -5 dolphin/src/kitemviews/kfileitemlistwidget.cpp M +4 -0 dolphin/src/kitemviews/kfileitemlistwidget.h M +14 -8 dolphin/src/kitemviews/kitemlistview.cpp M +9 -15 dolphin/src/kitemviews/kitemlistview.h M +4 -0 dolphin/src/settings/dolphin_detailsmodesettings.kcfg M +42 -5 dolphin/src/settings/viewmodes/viewsettingstab.cpp M +2 -0 dolphin/src/settings/viewmodes/viewsettingstab.h M +8 -0 dolphin/src/views/dolphinitemlistcontainer.cpp http://commits.kde.org/kde-baseapps/4763cb6235a66f4eba5ed436a99bd3dd07a2acc8 Git commit b3ea19c528cac1eada2a2e159d50dcd9be3c2aba by Peter Penz. Committed on 09/03/2012 at 16:23. Pushed by ppenz into branch 'master'. Provide UI-option for "Expandable folders" M +4 -8 dolphin/src/settings/viewmodes/viewsettingstab.cpp http://commits.kde.org/kde-baseapps/b3ea19c528cac1eada2a2e159d50dcd9be3c2aba Git commit 1d9074249fffe209296f6483572a11bbc885e0b2 by Peter Penz. Committed on 09/03/2012 at 16:27. Pushed by ppenz into branch 'master'. Folders Panel: Turn on items-expanding Since the fix of bug 289090 the items-expanding is not automatically turned on anymore when using the DetailsMode. M +1 -0 dolphin/src/panels/folders/folderspanel.cpp http://commits.kde.org/kde-baseapps/1d9074249fffe209296f6483572a11bbc885e0b2 Git commit 97662eee998f1c417be0ffa901d7063ca183585c by Peter Penz. Committed on 09/03/2012 at 16:27. Pushed by ppenz into branch 'KDE/4.8'. Folders Panel: Turn on items-expanding Since the fix of bug 289090 the items-expanding is not automatically turned on anymore when using the DetailsMode. M +1 -0 dolphin/src/panels/folders/folderspanel.cpp http://commits.kde.org/kde-baseapps/97662eee998f1c417be0ffa901d7063ca183585c @all: As for 4.8.x no new user-interface strings may be introduced, the line ExpandableFolders=false must be manually added below the section "[DetailsMode]" in the file ~/.kde/share/config/dolphinrc if the expandable-folders feature should be disabled for 4.8.x The master branch already contains the checkbox "Expandable folders" in the settings. @Peter Penz: Thank you very much! As of now, Dolphin is truly the best and most usable file manager, imho. *** Bug 297380 has been marked as a duplicate of this bug. *** Where can I send you beer money? > Where can I send you beer money?
I'll consume a beer today in the name of this bug ;-) But thanks for the offer!
*** Bug 296278 has been marked as a duplicate of this bug. *** |