| Summary: | French Kalendar | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kholidays | Reporter: | alexpremie |
| Component: | general | Assignee: | John Layt <jlayt> |
| Status: | REPORTED --- | ||
| Severity: | wishlist | CC: | annma, kde-francophone, kdepim-bugs, pierre+libre.kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
alexpremie
2011-12-03 15:35:49 UTC
Merci de transmettre à qui de droit au cas (probable) où je me serais planté dans la rubrique! Bug reports should be in English Translating: the user complains that the French file for holidays does not show only official holidays but some unofficial holidays as well. The bug is not in Plasma but in kdepimlibs/kholidays, reassigning with CC to French team The file is there: https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/master/changes/kholidays/holidays/plan2/holiday_fr_fr Alex if you want to look at it and submit a better proposal Tired today, wrong CC, sorry. When I updated the french holiday calendar, I was under the impression that each "type" of days would be selectable. It's clearly not the case, but I don't mind seeing them in green while the "important" ones are in red. Pentecôte Monday is an official holiday <http://www.codes-et-lois.fr/code-du-travail/article-l3133-1>. It was reinstated in 2008. As for the Alsatian holidays, John Layt was looking for a solution to create a special zone for Lorraine and Alsace, just like the over-seas dependencies; something to do with a country code if I remember right... Pierre, what about only keeping the public holidays and commenting the 'cultural' ones for 4.10 ? Unfortunately it's too late for 4.10. Nonetheless, your needs are legitimate and so if enough users show their support, I (or anyone else) will trim the file to your liking. In the meantime, know that you could copy "/usr/share/apps/libkholidays/plan2/holiday_fr_fr" to "~/.kde4/share/apps/libkholidays/plan2" and edit it to your liking. You'll need to disable/enable the calendar or logout to see the changes. PS: just for kicks, take a look at the file for New Zealand and despair at its completeness <https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/3e14b46e37b0d8e9ab79e6fc9b9e9b1e4646f211/entry/kholidays/holidays/plan2/holiday_nz_en-gb> Sadly I haven't got around to implementing proper categories or separate religious files yet, I may try for that next release. My usual recommendation is to have all public holidays included, and all major commemorative dates that are culturally significant (Mothers Day, etc). I usually recommend against including all the Saints days unless the country is particularly devout, but the most significant religious festivals are welcome. However it is up to each country to decide for themselves what is culturally appropriate. We can break each region out use the tier 2 ISO code, unfortunately each time we do we need a new translation string for the region name, so this can only be done each point release. If there are any holidays that are wrong, then changing the Holiday files themselves can be considered a bug fix so can go out with the next bugfix release. I'd probably even consider trimming a too long file as a usability bug fix. I'm not sure why the NZ file has so many religious holidays, we're not a very devout bunch :-) Catching up on the KHolidays bugs for the next release, we have a few days before the translation freeze to get any new region names added. According to http://en.wikipedia.org/wiki/ISO_3166-2:FR there are 22 Metropolitan regions and 78 Metropolitan departments defined for France. At what level would we want/need to define regional holidays? Which regions are we likely to have demand for separate files? In 4.14 we now have full category support, in addition to the category files we supported in 4.6. Let me know if you still want to do anything with splitting things up more. Are there still any mistakes in the holiday dates? > At what level would we want/need to define regional holidays? If it’s impossible to unite disparate divisions under a single header (“Alsace-Moselle” in this case) then it must be at the départements level. > Which regions are we likely to have demand for separate files? The exceptions are contained to 3 metropolitan départements: Bas-Rhin, Haut-Rhin and Moselle (Bas-Rhin and Haut-Rhin forming the region Alsace). > In 4.14 we now have full category support, in addition to the category files we supported in 4.6. Let me know if you still want to do anything with splitting things up more. Does this mean that we can have (or, in this bug case, need to) separate files for religious and cultural events ? Or are the categories selected via the GUI? > Are there still any mistakes in the holiday dates? Not really. Just a difference of opinion on how to interpret the law about Lundi de Pentecôte ;-) I’ll review your choices of categories (so far, no mistakes :-) ) and attach the revisions to this report. |