| Summary: | KMail crash when dragging mail to a folder | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] Akonadi | Reporter: | Aaron J. Seigo <aseigo> |
| Component: | libakonadi | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED UNMAINTAINED | ||
| Severity: | crash | CC: | amantia, boboudrescu, dilfridge, montel, myriam, pancho.s, winter |
| Priority: | NOR | ||
| Version: | 4.8 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Aaron J. Seigo
2011-11-30 17:11:46 UTC
I am pretty sure this is a duplicate of bug 285588 *** Bug 288492 has been marked as a duplicate of this bug. *** from bug 288492 (4.8beta2) -- Information about the crash: - What I was doing when the application crashed: 3 messages marked, right-click in message list & select "move to" with another dimap folder. Crash. (In reply to comment #3) > from bug 288492 (4.8beta2) > > -- Information about the crash: > - What I was doing when the application crashed: > > 3 messages marked, right-click in message list & select "move to" with another > dimap folder. Crash. This seems reproducible as long as the target folder is not yet in the "recently used folders list". On a related note, I cannot drag any messages from the message list directly into another folder; going via the context menu is the only working option. But this is likely a different bug. The problem is with the recently introduced mRecentCollectionMenu. This is a mapping between the action type and the RecentCollectionAction. There is an entry added to the map every time the menu is about to show. 1) first problem: even though the map holds a smart pointer, QPointer to the RecentCollectionAction (should be QWeakPointer), when the pointer value is read, it is not checked for null, that's why it crash. 2) the reason I didn't fix it simply by checking the value for null is that I see no place where entries are removed from the map. This looks wrong to me, so I let Laurent go through his code and fix it. :) Git commit 3bf8231b5c8064b02f7ca87aced1d717aee7e28d by Allen Winter. Committed on 10/12/2011 at 14:55. Pushed by winterz into branch 'master'. in addRecentCollection(), add a crash guard for item's value being 0. probably fixes the crash reported in 287923 BUG: 287923 FIXED-IN: 4.8.0 MERGE: could be merged to 4.7 is someone wants it M +3 -1 akonadi/standardactionmanager.cpp http://commits.kde.org/kdepimlibs/3bf8231b5c8064b02f7ca87aced1d717aee7e28d reopening... the commit I made will fix the crash but doesn't fix the real problem and we really should look at seeing why the map has null values and why the map is not cleaned up. so for future reference let's keep this one open How does this one relate to Bug #287923? I'd say they're duplicates, though obviously two different fixes have been committed. I'd tend to mark the other one a duplicate of this, because only the other one stopped people from reporting. There's a great number of obviously similar tickets around, I might then collect and close them as duplicates as well. But we should figure out which one we want to take as the root ticket. Sorry, I meant: How does this one relate to Bug #285588? This bug has only been reported for versions older than KDEPIM 4.14 (at most akonadi-1.3). Can anyone tell if this bug still present? If noone confirms this bug for a recent version of akonadi (part of KDE Applications 15.08 or later), it gets closed in about three months. Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input. |