| Summary: | KPluginSelector freezes in Amarok and KRunner, but not in KWin settings (4.7.80 regression) | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | K900 <me> |
| Component: | kdeui | Assignee: | kdelibs bugs <kdelibs-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | wengxt |
| Priority: | NOR | Keywords: | regression |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
K900
2011-11-29 15:42:18 UTC
Tested on a clean setup and with other video drivers (Nouveau), and it's still 100% reproducible Most definitely related to https://git.reviewboard.kde.org/r/103165/diff/#5.2 . The rest of the patch seems ok though. Reverted this in Agilia packaging. Git commit 70c6350fac3ab2b74d61811606eb250da7c5a061 by Thomas Lübking. Committed on 01/12/2011 at 19:46. Pushed by luebking into branch 'KDE/4.7'. Fix regression induced (but likely not caused) by commit e91e5fed6b1aad365e12e919f430c3e8147552d3 Commiting on behalf of Jaime Torres. Ratio: On k-c-d I suggested this would be another ouotcome of bug #213068 and Jaime could confirm this and the scrollbar policy workaround to work. He suggested to fix it by "setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);" instead (since presumingly the pluginselector is always top-down oriented) I tested that variant as well and could not reproduce the issue. Since Jaime has no acces to his development environment for today he asked me to either revert his commit or apply the hotfix working around bug #213068 as mentioned above. Because i could not spot any bug in his commit i'll go with the hotfix to prevent a regression. Resolving the actual recursion bug is an outstanding issue. CCBUG: 213068 CCBUG: 287847 M +1 -0 kutils/kpluginselector.cpp http://commits.kde.org/kdelibs/70c6350fac3ab2b74d61811606eb250da7c5a061 *** Bug 287213 has been marked as a duplicate of this bug. *** @Thomas: Is anyone still looking into this or are you leaving the workaround there? I tried to find the issue, but I'm not really good at C++... Git commit ee00a9f572a383b98c4fd01f0b0477ff9148c5d7 by Aaron Seigo, on behalf of Thomas Lübking. Committed on 01/12/2011 at 19:46. Pushed by aseigo into branch 'frameworks'. Fix regression induced (but likely not caused) by commit e91e5fed6b1aad365e12e919f430c3e8147552d3 Commiting on behalf of Jaime Torres. Ratio: On k-c-d I suggested this would be another ouotcome of bug #213068 and Jaime could confirm this and the scrollbar policy workaround to work. He suggested to fix it by "setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);" instead (since presumingly the pluginselector is always top-down oriented) I tested that variant as well and could not reproduce the issue. Since Jaime has no acces to his development environment for today he asked me to either revert his commit or apply the hotfix working around bug #213068 as mentioned above. Because i could not spot any bug in his commit i'll go with the hotfix to prevent a regression. Resolving the actual recursion bug is an outstanding issue. CCBUG: 213068 CCBUG: 287847 M +1 -0 kutils/kpluginselector.cpp http://commits.kde.org/kdelibs/ee00a9f572a383b98c4fd01f0b0477ff9148c5d7 (In reply to comment #5) > @Thomas: Is anyone still looking into this or are you leaving the workaround > there? I tried to find the issue, but I'm not really good at C++... Sorry for the delay, i'm not subscribed to this bug. I think we've a proper fix: https://git.reviewboard.kde.org/r/103335/ It would be great if you could give it a try and confirm or deny the solution. Git commit 08325ba32b72326030004cc28430431193d82fc2 by Thomas Lübking. Committed on 05/12/2011 at 14:56. Pushed by luebking into branch 'KDE/4.7'. fix KCategorizedView race BUG: 213068 BUG: 287847 REVIEW: 103335 QListView::updateGeometries() has it's own opinion on whether the scrollbars should be visible (valid range) or not and triggers a (sometimes additionally timered) resize through ::layoutChildren() http://qt.gitorious.org/qt/qt/blobs/4.7/src/gui/itemviews/qlistview.cpp#line1499 (the comment above the main block isn't all accurate, layoutChldren is called regardless of the policy) As a result QListView and KCategorizedView occasionally started a race on the scrollbar visibility, effectively blocking the UI So we prevent QListView from having an own opinion on the scrollbar visibility by fixing it before calling the baseclass QListView::updateGeometries() and restoring the policy afterwards M +23 -1 kdeui/itemviews/kcategorizedview.cpp M +0 -2 kutils/kpluginselector.cpp http://commits.kde.org/kdelibs/08325ba32b72326030004cc28430431193d82fc2 Git commit 8095c11d181e967cb161de3452f45c1df81bbc66 by Thomas Lübking. Committed on 08/12/2011 at 18:58. Pushed by luebking into branch 'KDE/4.7'. Fix KCategorizedView race - better :p BUG: 213068 BUG: 287847 REVIEW: 103335 M +24 -9 kdeui/itemviews/kcategorizedview.cpp http://commits.kde.org/kdelibs/8095c11d181e967cb161de3452f45c1df81bbc66 |