Summary: | Crash when sycoca is updated | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | Christoph Feck <cfeck> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | boboudrescu, myriam |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Christoph Feck
2011-11-29 00:45:09 UTC
duplicate of Bug 283303 Yes, same backtrace, looks like bug 283303 reappeared... Git commit a8b49bc65afb1d05e7de0148c3116f2f6a1f98de by Aaron Seigo. Committed on 30/11/2011 at 09:17. Pushed by aseigo into branch 'KDE/4.7'. grab the source name before removing the iterator the previous fix, which i accidentally reverted while cleaning up this code, was actually wrong (so in a way i'm glad i caught it): the signal MUST be emitted AFTER the item is removed from the collection otherwise any code that checks to see if that source exists will see that it does still exist even though it was just signaled as being removed. order sometimes really matters :) CCMAIL:kde@rusu.info BUG:287795 M +3 -2 plasma/dataengine.cpp http://commits.kde.org/kdelibs/a8b49bc65afb1d05e7de0148c3116f2f6a1f98de Git commit c0e531bae10f0d80b30ae18033d12077a2c2ef32 by Aaron Seigo. Committed on 30/11/2011 at 09:17. Pushed by aseigo into branch 'frameworks'. grab the source name before removing the iterator the previous fix, which i accidentally reverted while cleaning up this code, was actually wrong (so in a way i'm glad i caught it): the signal MUST be emitted AFTER the item is removed from the collection otherwise any code that checks to see if that source exists will see that it does still exist even though it was just signaled as being removed. order sometimes really matters :) CCMAIL:kde@rusu.info BUG:287795 M +3 -2 plasma/dataengine.cpp http://commits.kde.org/kdelibs/c0e531bae10f0d80b30ae18033d12077a2c2ef32 |