| Summary: | kdewebkit does not ask whether to remember password on renren.com | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | moriramar |
| Component: | kdewebkit | Assignee: | webkit-devel |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | adawit, bugz57, christoph, marcus |
| Priority: | NOR | ||
| Version: | 4.7 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
moriramar
2011-11-27 15:50:07 UTC
(In reply to comment #0) > Version: unspecified (using KDE 4.7.2) > OS: Linux > > I go to renren.com and log in, but KWebkitPart does not ask me whether to > remember password there. > > I am using kwebkitpart 1.2.0 from Gentoo Portage. > > Thank you. > > Reproducible: Always > > Steps to Reproduce: > 1. Open Konqueror 4.7.2 and enable Webkit mode. > 2. Go to http://www.renren.com . > 3. Type an email address string in the first textbox and an password-like > string in the second textbox. > 4. Click the blue box (not the green one) just under the two textboxes. > > Actual Results: > The form is submitted but KWebkitpart does not tell me to remember password. > > Expected Results: > KWebkitpart asks me whether to remember password. I cannot get past the the login captcha or is it the site telling me the fake login/password I am was is wrong ??? I have no idea since I cannot read Chinese ; so I am unable to test the page. The red line on the right upper part of the login box is just saying fake login/password. My login account is moriramar@gmail.com . and the password is testpass . (I am going to abandon this account so it does not matter.) Git commit e80f2b3c88911b549c2870091542ee32233d9293 by Dawit Alemayehu. Committed on 27/12/2011 at 15:21. Pushed by adawit into branch 'KDE/4.8'. Since QWebFrame::url() always returns an empty URL for child frames, use QWebFrame::baseUrl() instead. M +10 -5 kdewebkit/kwebwallet.cpp http://commits.kde.org/kdelibs/e80f2b3c88911b549c2870091542ee32233d9293 (In reply to comment #2) > The red line on the right upper part of the login box is just saying fake > login/password. > > My login account is moriramar@gmail.com . and the password is testpass . (I am > going to abandon this account so it does not matter.) Well now I get a yellow box over the login input boxes with the following text 您的帐号由于以下某种原因需要解 锁才能登录 删除过帐号 长时间没有登录网站 安全原因 Followed by a link that states 立即解锁. When KDE 4.8.0 comes out, please test and see if the patch I applied in comment #3 helps resolve this issue. No clue what Git commit 2bcb2bc6ff83f91d1462774ca9bd104d3a2bb9f7 by Sebastian Trueg, on behalf of Dawit Alemayehu. Committed on 27/12/2011 at 15:21. Pushed by trueg into branch 'KDE/4.8'. Since QWebFrame::url() always returns an empty URL for child frames, use QWebFrame::baseUrl() instead. M +10 -5 kdewebkit/kwebwallet.cpp http://commits.kde.org/kdelibs/2bcb2bc6ff83f91d1462774ca9bd104d3a2bb9f7 Ok, this is caused by a known issue. Namely, the hack we use to capture the login information from a website will not work if the login is handled through Javascript through XMLHttpRequest or Ajax. Will have to figure out an elegant solution to address this whole capture login information stuff. What source code/documentation would I have to study to understand how form information is captured? kdelibs/kdewebkit/kwebwallet.* The code that does the capturing is written in javascript for the reasons listed in bug# 323663. I've not had chance to look at the source code yet, but I've followed the trail of bug-reports back to QWebFrame::findAllElements() not actually finding all the elements. Is sloppily hacking around that a worthwhile endeavour, or should I not bother? KDEWebkit got deprecated/removed. |