Summary: | Amarok crashes when trying to save cover art for files not in the collection [@ CoverFoundDialog::saveAs] | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Martin <martin.ruessler> |
Component: | Tools/Cover Manager | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | stuffcorpse |
Priority: | NOR | ||
Version: | 2.4.3 | ||
Target Milestone: | 2.6 | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.5 | |
Sentry Crash Report: |
Description
Martin
2011-11-26 13:06:25 UTC
Could you please check this comment and try to see if that helps? -> https://bugs.kde.org/show_bug.cgi?id=251250#c2 Ok, it seems that the bug is only valid for items which are not in the Amarok database i.e. new files or renamed ones (but reproducible with those). Does it still count as bug or is it just a missing feature? If so, a warning/clarification would be nice. Anyway, thank you for pointing me to that comment. I did not read it carefully enough last time. Yes, this still counts as a bug as it shouldn't crash. I changed the title accordingly. Git commit 0a84b26398ac8d859144c37d5e426f96e918d3e6 by Rick W. Chen. Committed on 01/12/2011 at 03:27. Pushed by rickc into branch 'master'. Disable cover fetching action for tracks not in the collection BUG: 287604 FIXED-IN: 2.5 M +2 -0 ChangeLog M +6 -0 src/covermanager/CoverFetchingActions.cpp M +8 -1 src/covermanager/CoverFoundDialog.cpp http://commits.kde.org/amarok/0a84b26398ac8d859144c37d5e426f96e918d3e6 Git commit b9ba782d7222e82fe9546b5c891855a93d421ad0 by Matěj Laitl. Committed on 05/01/2012 at 18:05. Pushed by laitl into branch 'master'. CoverFetchAction: disable according to canUpdateImage() method Previous algorithm only worked from MetaFile::Album, this one works for it and for all albums that correctly implement Meta::Album interface. M +7 -6 src/covermanager/CoverFetchingActions.cpp http://commits.kde.org/amarok/b9ba782d7222e82fe9546b5c891855a93d421ad0 |