Bug 286700

Summary: Failed to copyFile: "Entry '/ppt/slides/NULL' not found.
Product: [Applications] calligrastage Reporter: LukasT <lukast.dev>
Component: filter/pptxAssignee: Matus Uzak <matus.uzak>
Status: RESOLVED FIXED    
Severity: normal CC: matus.uzak, sebsauer
Priority: NOR    
Version: 2.4-snapshots   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description LukasT 2011-11-15 16:00:24 UTC 
Version:           2.4-snapshots (using KDE 4.7.3) 
OS:                Linux

Crashing file is referenced in this bug.

Reproducible: Always

Steps to Reproduce:
1. Try to open file at [1]
2. Crash

[1] http://bioengreu.slu.edu/projects09/kunkel/webpage_files/final_pres.ppt

Actual Results:  
Crash

Expected Results:  
Display the content of the file [1]
OOo displays the file.

Application: Stage (calligrastage), signal: Segmentation fault
[KCrash Handler]
#7  0x00a9726d in KoXmlWriter::Private::~Private (this=0x72673a70, __in_chrg=<value optimized out>) at /home/lukas/src/calligra/libs/odf/KoXmlWriter.cpp:36
#8  0x00a9581a in KoXmlWriter::~KoXmlWriter (this=0x38d8f71, __in_chrg=<value optimized out>) at /home/lukas/src/calligra/libs/odf/KoXmlWriter.cpp:69
#9  0x038a8c8a in MSOOXML::Utils::AutoPtrSetter<KoXmlWriter>::~AutoPtrSetter (this=0xbfabf0d8, __in_chrg=<value optimized out>) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlUtils.h:215
#10 0x03869902 in PptxXmlSlideReader::read_spTree (this=0xbfac0370) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlSlideReader.cpp:1418
#11 0x03866886 in PptxXmlSlideReader::read_cSld (this=0xbfac0370) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlSlideReader.cpp:1122
#12 0x03860d17 in PptxXmlSlideReader::read_sldInternal (this=0xbfac0370) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlSlideReader.cpp:506
#13 0x03860557 in PptxXmlSlideReader::read_sld (this=0xbfac0370) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlSlideReader.cpp:396
#14 0x03860078 in PptxXmlSlideReader::readInternal (this=0xbfac0370) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlSlideReader.cpp:324
#15 0x0385faba in PptxXmlSlideReader::read (this=0xbfac0370, context=0xbfac0c00) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlSlideReader.cpp:266
#16 0x03db6192 in MSOOXML::Utils::loadAndParseDocument (reader=0xbfac0370, zip=0x8c87350, writers=0xbfac0378, errorMessage=..., fileName=..., context=0xbfac0c00) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlUtils.cpp:213
#17 0x03deda4c in MSOOXML::MsooXmlImport::loadAndParseDocument (this=0x8d954d0, reader=0xbfac0370, path=..., context=0xbfac0c00) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlImport.cpp:722
#18 0x03818d72 in PptxXmlDocumentReader::read_sldId (this=0xbfac1738) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlDocumentReader.cpp:360
#19 0x0381c1fb in PptxXmlDocumentReader::read_sldIdLst (this=0xbfac1738) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlDocumentReader.cpp:617
#20 0x0381ec5a in PptxXmlDocumentReader::read_presentation (this=0xbfac1738) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlDocumentReader.cpp:883
#21 0x03816cc7 in PptxXmlDocumentReader::readInternal (this=0xbfac1738) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlDocumentReader.cpp:166
#22 0x038166bf in PptxXmlDocumentReader::read (this=0xbfac1738, context=0xbfac1ba8) at /home/lukas/src/calligra/filters/stage/pptx/PptxXmlDocumentReader.cpp:116
#23 0x03db6192 in MSOOXML::Utils::loadAndParseDocument (reader=0xbfac1738, zip=0x8c87350, writers=0xbfac1e80, errorMessage=..., fileName=..., context=0xbfac1ba8) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlUtils.cpp:213
#24 0x03ded85c in MSOOXML::MsooXmlImport::loadAndParseDocumentFromFileInternal (this=0x8d954d0, fileName=..., reader=0xbfac1738, writers=0xbfac1e80, errorMessage=..., context=0xbfac1ba8, pathFound=0xbfac16ff) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlImport.cpp:664
#25 0x03ded76e in MSOOXML::MsooXmlImport::loadAndParseDocumentInternal (this=0x8d954d0, contentType=..., reader=0xbfac1738, writers=0xbfac1e80, errorMessage=..., context=0xbfac1ba8, pathFound=0xbfac16ff) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlImport.cpp:649
#26 0x03ded8bb in MSOOXML::MsooXmlImport::loadAndParseDocument (this=0x8d954d0, contentType=..., reader=0xbfac1738, writers=0xbfac1e80, errorMessage=..., context=0xbfac1ba8) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlImport.cpp:675
#27 0x03813f55 in PptxImport::parseParts (this=0x8d954d0, writers=0xbfac1e80, relationships=0xbfac1c64, errorMessage=...) at /home/lukas/src/calligra/filters/stage/pptx/PptxImport.cpp:1116
#28 0x03dedd94 in MSOOXML::MsooXmlImport::openFile (this=0x8d954d0, writers=0xbfac1e80, errorMessage=...) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlImport.cpp:763
#29 0x03de6b23 in MSOOXML::MsooXmlImport::createDocument (this=0x8d954d0, outputStore=0x8f684f0, writers=0xbfac1e80) at /home/lukas/src/calligra/filters/libmsooxml/MsooXmlImport.cpp:146
#30 0x03ea2852 in KoOdfExporter::convert (this=0x8d954d0, from=..., to=...) at /home/lukas/src/calligra/filters/libmsooxml/KoOdfExporter.cpp:121
#31 0x00e3829b in CalligraFilter::ChainLink::invokeFilter (this=0x8cd7708, parentChainLink=0x0) at /home/lukas/src/calligra/libs/main/KoFilterChainLink.cpp:90
#32 0x00e2ec54 in KoFilterChain::invokeChain (this=0x8d8f948) at /home/lukas/src/calligra/libs/main/KoFilterChain.cpp:94
#33 0x00e288a6 in KoFilterManager::importDocument (this=0x8d31ad8, url=..., documentMimeType=..., status=@0xbfac2174) at /home/lukas/src/calligra/libs/main/KoFilterManager.cpp:170
#34 0x00dd5bc8 in KoDocument::openFile (this=0x8bfa588) at /home/lukas/src/calligra/libs/main/KoDocument.cpp:1495
#35 0x00d33a15 in ?? () from /usr/lib/libkparts.so.4
#36 0x00d3410b in KParts::ReadOnlyPart::openUrl(KUrl const&) () from /usr/lib/libkparts.so.4
#37 0x00dd49de in KoDocument::openUrl (this=0x8bfa588, _url=...) at /home/lukas/src/calligra/libs/main/KoDocument.cpp:1254
#38 0x00dfa4bd in KoMainWindow::openDocumentInternal (this=0x8b6f8c0, url=..., newdoc=0x8bfa588) at /home/lukas/src/calligra/libs/main/KoMainWindow.cpp:643
#39 0x00dfa35c in KoMainWindow::openDocument (this=0x8b6f8c0, newdoc=0x8bfa588, url=...) at /home/lukas/src/calligra/libs/main/KoMainWindow.cpp:626
#40 0x00dca66e in KoApplication::start (this=0xbfac2804) at /home/lukas/src/calligra/libs/main/KoApplication.cpp:282
#41 0x00cdbe7a in kdemain (argc=2, argv=0xbfac2914) at /home/lukas/src/calligra/stage/part/main.cpp:41
#42 0x08048789 in main (argc=2, argv=0xbfac2914) at /home/lukas/src/build/calligra/stage/part/calligrastage_dummy.cpp:3
Comment 1 Sebastian Sauer 2011-11-16 18:44:14 UTC 
Crash was fixed with commit 2e55d61817df5. The error-message on loading those pptx is still there and needs to be fixed.
Comment 2 Matus Uzak 2012-03-14 15:40:13 UTC 
The obsolete code removed by Sebastian is still in for some reason.  

The problem is in the relationships file of slide6:  <Relationship Id="rId2" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/image" Target="NULL"/>

ECMA-376 Office Open XML File Formats – Part 2
The Target attribute shall be a URI reference pointing to a target resource.  The URI reference shall be a URI or a relative reference.
Comment 3 Matus Uzak 2012-03-14 17:41:20 UTC 
Git commit f64c626b40bcbfcc8f05627358fdbf85f14d7502 by Matus Uzak.
Committed on 14/03/2012 at 17:56.
Pushed by uzak into branch 'master'.

libmsooxml: Don't process a blip in case Target="NULL" in relationships file.

ECMA-376 Office Open XML File Formats – Part 2
The Target attribute shall be a URI reference pointing to a
target resource.  The URI reference shall be a URI or a relative
reference.

The test file attached to the bug seems odd, so I did not add the
condition to all places where embedded objects are processed.

M  +6    -0    filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h
M  +4    -4    filters/stage/pptx/PptxXmlDocumentReader.cpp
M  +4    -6    filters/stage/pptx/PptxXmlSlideReader.cpp

http://commits.kde.org/calligra/f64c626b40bcbfcc8f05627358fdbf85f14d7502