Bug 286683

Summary: Make common-internals look like library code
Product: [Unmaintained] telepathy Reporter: David Edmundson <kde>
Component: common-internalsAssignee: Dario Freddi <drf>
Status: RESOLVED FIXED    
Severity: normal CC: drf
Priority: NOR    
Version: unspecified   
Target Milestone: 0.4.0   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Bug Depends on:    
Bug Blocks: 285413    

Description David Edmundson 2011-11-15 12:42:41 UTC 
This means every header file needs reviewing for:
 - sane, simple API
 - documentation
 - use of Q_SLOTS vs slots (etc.)
 - check for d pointers + other library like stuff
 - Put everything in KTelepathy namespace(?)

circular-countdown.h
error-dictionary.h
global-presence.h
kpresence.h
service-availability-checker.h
telepathy-handler-application.h
text-parser.h
wallet-interface.h

models/
accounts-filter-model.cpp
accounts-filter-model.h
accounts-model.cpp
accounts-model.h
accounts-model-item.cpp
accounts-model-item.h
contact-model-item.cpp
contact-model-item.h
groups-model.cpp
groups-model.h
groups-model-item.cpp
groups-model-item.h
proxy-tree-node.cpp
proxy-tree-node.h
tree-node.cpp
tree-node.h

Please comment if you've edited a file that you're happy for it to be reviewed - or that you think a file is ok.
Comment 1 Dario Freddi 2011-11-18 22:01:43 UTC 
I'm taking care of this
Comment 2 Dario Freddi 2011-11-23 21:27:14 UTC 
Oh, damn you bugzilla for not recognizing my "other" address. Whatevz, committed. Further reference here if needed: https://git.reviewboard.kde.org/r/103183/