Bug 286213

Summary:	Digikam allows RAW (ORF) photos to be rotated, but then fails
Product:	[Applications] digikam	Reporter:	Thomas Damgaard <thomasdn>
Component:	Plugin-DImg-RAW	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, thomasdn
Priority:	NOR
Version First Reported In:	2.3.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	2.6.0
Sentry Crash Report:

Description Thomas Damgaard 2011-11-09 20:00:42 UTC

Version:           2.3.0 (using KDE 4.7.2) 
OS:                Linux

Digikam shows an option to rotate .ORF files (Olympus RAW photos),
however, this action always fails -- because it is appearently not
implemented. Since it does not work, it should not be shown.

Please, either remove action from the UI until it is implemented -- or
implement support for rotating RAW images.

Reproducible: Always

Steps to Reproduce:
Select an .ORF file.
Press rotate-arrow on image overlay to rotate image (or ctrl+shift+left).


Actual Results:  
An error appears.

Expected Results:  
Image should be rotated.

DistroRelease: Ubuntu 11.10
Package: digikam 2:2.1.1-0ubuntu1
ProcVersionSignature: Ubuntu 3.0.0-12.20-generic 3.0.4
Uname: Linux 3.0.0-12-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 1.23-0ubuntu4
Architecture: amd64
Date: Wed Nov  9 20:15:36 2011
InstallationMedia: Kubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111011)
ProcEnviron:
 LANGUAGE=en_DK:en
 PATH=(custom, user)
 LANG=en_DK.UTF-8
 SHELL=/bin/zsh
SourcePackage: digikam

Comment 1 caulier.gilles 2011-11-12 13:48:48 UTC

RAW are read only image. This is why RAw files cannot be rotated...

Gilles Caulier

Comment 2 Thomas Damgaard 2011-11-13 15:42:04 UTC

RAW images may be read only in digikam, however, it is still possible to improve the user experience and fix this bug. Here are two possible solutions:

Solution 1: Even though the RAW image itself is read only, the image that digikam *displays* to the user (eg. thumbnail, preview, etc.) does not have to be. So if the user has rotated a RAW image 90 degrees clockwise, this information about the rotation can be stored in the DB. So when digikam displays this RAW image, the user is presented with a rotated version. This, the RAW file itself is never touched.

Solution 2: If RAW images are read only and should it is impossible for the user to rotate them (or even elect to have them *displayed* rotated), the rotate function will always fail for the user and should thus not be shown for RAW images (and other file types that will fail -- e.g. videos and such).

Comment 3 caulier.gilles 2012-01-25 08:24:55 UTC

With next digiKam 2.6.0 (current implementation from Git/master), RAW thumbs/preview can be rotated. RAW file still untouched (read-only)...

Gilles Caulier