Bug 286179

Summary:	KDE 4.7.3 REGRESSION: device notifier shows non-removable disks even if told not to do so
Product:	[Unmaintained] solid	Reporter:	Sergio <sergio.callegari>
Component:	libsolid-udisks	Assignee:	Lukáš Tinkl <lukas>
Status:	RESOLVED FIXED
Severity:	normal	CC:	balcaen.john, lightningstrike35, yartsa
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch to fix the list of all hdd in device notifier

Description Sergio 2011-11-09 11:34:23 UTC

Version:           unspecified (using KDE 4.7.3) 
OS:                Linux

This is a regression of 4.7.3. Version 4.7.2 was fine.

The device notifier now lists all system partitions of my system (home, opt, local and so on).

I wonder if this may be due to the fact that these partitions are on lvm. But again, 4.7.2 could manage this just fine.

I also wonder if this may be related to changes made to better recognize external devices such as esata as removable.

Reproducible: Always

Steps to Reproduce:
1) Boot your system
2) Click on the device notifier icon


Actual Results:  
See all of your system filesystems come up in a long long list

Expected Results:  
See only available removable filesystems come up

My boot partition, the only that is not under lvm, does not come up.
This makes me think that the problem is only limited to the identification of lvm partitions as non removable.

Unfortunately, the kde 4.7.3 changelog page is completely broken. Clicking on 
"show all svn changes" returns a "Not found" (e.g., "The requested URL /announcements/changelogs/4_7_3/kdelibs.txt was not found on this server"), so it is quite uncomfortable to me to try to see what has been changed.

Anyway, in the future please assure that changes to solid are tested on systems with enterprise configurations (as lvm, software raid, etc) before entering a stabilization release (causing it to actually result in regressions).

Comment 1 Balcaen John 2011-11-13 22:18:04 UTC

Created attachment 65626 [details]
Patch to fix the list of all hdd in device notifier

In fact it seems this is related to this commit : https://projects.kde.org/projects/kde/kdelibs/repository/revisions/e1b3ce8115795e85f13b16011634cad3f8ee1e28

Reversing part of it allows me to fix it locally, but i don't know if this change is correct since i'm not sure if LUKS partition will be shown in dolphin (i don't have any of them).

Regards

Comment 2 Thorsteinn A. Malmjursson 2011-11-14 21:58:36 UTC

I do not see this error present in my distro (Kubuntu 11.10 running KDE 4.7.3) - all of my devices, like you, except for boot partition, are on lvm - but my device notifier is set up to show Removable devices only, and does precisely that.  It shows none of my non-removable devices in the device notifier window at all. I'd tag this as possibly being distro level, rather than an application fault.

Comment 3 Sergio 2011-11-15 13:46:26 UTC

Sort of weird. I also have kubuntu 11.10 with kde 4.7.3.

And the bug appears systematically on all the machines with this setup. Did not happen with 4.7.2. The notifier is set up to show removable devices only. And it shows local, home, opt, etc from the internal disk.

Comment 4 Thorsteinn A. Malmjursson 2011-11-15 14:57:52 UTC

Peculiar indeed, Sergio - is there any possibility this could be related to the hardware inside the machine interacting differently? My machine is pretty old, so I don't know whether it's software related, hardware related, or just plain picky :)

Comment 5 Jari Laamanen 2011-11-15 23:45:55 UTC

I have this bug in my Kubuntu 11.10, KDE 4.7.3. Like Sergio, only partitions which are on LVM are shown, and boot and, e.g., windows partitions are not shown. My one LUKS encrypted partition shows up twice in the list, the first being "Encrypted container" and the second just "Hard drive".

These partitions also appeared in Dolphin's Places tab, but I cannot say for sure if they have always been there, as I do not use it so often. However, now they caught my eye.

Comment 6 Jari Laamanen 2012-01-28 14:53:01 UTC

Seems to be fixed in kde 4.8.0.

Comment 7 Sergio 2012-01-28 15:21:41 UTC

I confirm that 4.8.0 appears to work in the correct way.  Unless there are others for which the bug persists, I think it can be closed.