Bug 286108

Summary:	Regression: Krita doesn't save new presets.
Product:	[Applications] krita	Reporter:	Ico_dY <enrico_guarnieri>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	major	CC:	halla
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Preset added to blacklist. Blacklist.

Description Ico_dY 2011-11-08 13:49:58 UTC

Version:           svn trunk
OS:                Linux

If I create a new preset giving a name and clicking the "save to presets" button, Krita doesn't save it into the "paintoppresets" folder; so closing and reopening the program, the preset disappears from the list.

I'm using the last version compiled from git under Mint 10 (Ubuntu Maverick).

Reproducible: Always



Expected Results:

Comment 1 Ico_dY 2011-11-08 13:59:33 UTC

I've just deleted all configuration files and restarted Krita.
It seems to work correctly now..

Comment 2 Ico_dY 2011-11-08 14:17:48 UTC

Ohi-ohi, sometimes Krita saves the preset into the "paintoppresets" folder, but after restarting doesn't show it... ;^^

Comment 3 Halla Rempt 2011-11-08 14:27:06 UTC

Hm... Sounds like something is going wrong with the blacklist we use to hide deleted presets.

Comment 4 Sven Langkamp 2011-11-14 19:58:28 UTC

Could you attach the kis_paintoppresets.blacklist and the preset that doesn't load?

Comment 5 Ico_dY 2011-11-14 20:39:15 UTC

It's too late... ;^^
After the latest changes in git, Krita worked perfectly for me and I deleted everything thinking the problem was solved.

I'm so sorry! :(

I don't have any problem now and can't reproduce the bug. 
Sorry, again...

Comment 6 Sven Langkamp 2011-11-14 20:42:09 UTC

Ok, I'm closing the bug as works. If it reappears please reopen.

Comment 7 Ico_dY 2011-11-17 15:37:45 UTC

Created attachment 65784 [details]
Preset added to blacklist.

Comment 8 Ico_dY 2011-11-17 15:38:34 UTC

Created attachment 65785 [details]
Blacklist.

Comment 9 Ico_dY 2011-11-17 16:02:45 UTC

The problem appeared again, but this time I've kept a sample of the preset! ^^
Please, look in attachment! Just as Boudewijn said, sometimes Krita adds the presets to the blacklist without reason...

Comment 10 Sven Langkamp 2011-11-22 17:46:00 UTC

File are only added to the blacklist if the file is removed. Could it be that you removed a preset and then added one with the same name?

Comment 11 Ico_dY 2011-11-22 21:21:17 UTC

Bingo! This is the problem... I've just tried!
1) Create a new preset.
2) Delete it.
3) Create a new one with the same name.
4) Close Krita.
5) Reopen Krita.
Result: the preset doesn't appear since it's in the blacklist! ^^

Comment 12 Halla Rempt 2011-11-23 17:59:37 UTC

Good detective work!

Comment 13 Sven Langkamp 2011-12-16 20:46:47 UTC

Git commit cdacaf63e643e54541d107c4eb7e0ced860d20e5 by Sven Langkamp.
Committed on 16/12/2011 at 21:43.
Pushed by langkamp into branch 'master'.

if file already exists, save resource with a new name
BUG:286108

M  +4    -12   krita/ui/kis_paintop_box.cc
M  +14   -1    libs/widgets/KoResourceServer.h

http://commits.kde.org/calligra/cdacaf63e643e54541d107c4eb7e0ced860d20e5