Bug 286045

Summary:	missing error handling in folder view / Unknown error. (Unable to fetch item from backend)
Product:	[Applications] kmail2	Reporter:	Milian Wolff <mail>
Component:	folders	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	winter
Priority:	NOR
Version:	Git (master)
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:

Description Milian Wolff 2011-11-07 21:21:42 UTC

Version:           Git (master) (using KDE 4.7.3) 
OS:                Linux

very often when I try to view the contents of a folder, kmail2 will show a spinner next to that folder but won't finish the view job. In the console I can see this:

kmail2(25075)/libakonadi Akonadi::EntityTreeModelPrivate::fetchJobDone: Job error:  "Unknown error. (Unable to fetch item from backend)"

but:
- the user won't see this in 99% of the cases as he won't check the cli output
- the folder is still shown in the "loading/spinning" status, even though the job finished (though with an error)
- I must restart kmail2 to try again to see the contents of this folder, probably related to the point above

I'll create another report about why this error might happen in the first place

Reproducible: Didn't try

Steps to Reproduce:
- toggle dimap account offline in akonadiconsole
- try to get folder contents of that offline account in kmail2

Actual Results:  
- endlessly spinning folder

Expected Results:  
- error message "resource is offline - go online? [yes] [no]"

Comment 1 Milian Wolff 2011-11-07 22:19:55 UTC

ignore Reproducible: Didn't try, 
it's always reproducible for me after supsend/resume and sometimes reproducible on normal kde startup after boot

Comment 2 Milian Wolff 2011-11-20 23:30:59 UTC

Git commit 224365efdba858ae226f498f4a74c6313f2bfd9e by Milian Wolff.
Committed on 21/11/2011 at 00:27.
Pushed by mwolff into branch 'master'.

proper error handling of fetch jobs in ETM

cleanup m_pendingCollectionRetrieveJobs on error as otherwise
the collection can never be retrieved after an error

furthermore display the error to the user in a dialog

CCBUG: 286045

M  +5    -2    akonadi/entitytreemodel_p.cpp

http://commits.kde.org/kdepimlibs/224365efdba858ae226f498f4a74c6313f2bfd9e

Comment 3 Allen Winter 2011-11-23 20:16:16 UTC

Git commit 47374d0b71f5154f0cda033c4c85c716a2705e84 by Allen Winter, on behalf of Milian Wolff.
Committed on 21/11/2011 at 00:27.
Pushed by winterz into branch 'KDE/4.7'.

proper error handling of fetch jobs in ETM

cleanup m_pendingCollectionRetrieveJobs on error as otherwise
the collection can never be retrieved after an error

furthermore display the error to the user in a dialog

CCBUG: 286045
(cherry picked from commit 224365efdba858ae226f498f4a74c6313f2bfd9e)

M  +5    -2    akonadi/entitytreemodel_p.cpp

http://commits.kde.org/kdepimlibs/47374d0b71f5154f0cda033c4c85c716a2705e84

Comment 4 Allen Winter 2011-11-23 22:21:34 UTC

Milian, can we resolve this as fixed?

Comment 5 Milian Wolff 2011-11-23 22:31:52 UTC

right I think we can actually