| Summary: | 8 keyboard layouts configured, message that only 4 are allowed. | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Dotan Cohen <kde-2011.08> |
| Component: | kcm_keyboard_layout | Assignee: | Andriy Rysin <arysin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | adaptee, kde-2011.08, vityatheboss |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kde-workspace/7c599bae516c61365c4eda2be998c97594e3b1af | Version Fixed In: | 4.11 |
| Sentry Crash Report: | |||
|
Description
Dotan Cohen
2011-11-02 13:48:17 UTC
Confirmed. The question is shall I just fix the message (to say only up to 8 allowed) or you really need more than 8 keyboard layouts? I don't want to make it limitless but if there's a need for >8 I guess we could bump the limit a bit. I personally only need four, but a user recently contacted me who needs 5. I also remember a user once who wanted 6 layouts, for different family members. I would suggest updating the message to say "8" and also allowing the "Main Layout Count" go up to 8. Alternatively, if you would like to mentor me this looks like the perfect easy bug to start learning KDE development. I have read the Getting Started/Build guide [1] but it assumes some prior knowledge. Investing some time in teaching me might save you some time in the future! I'm signing up for the kde-devel list now. Thanks. [1] http://techbase.kde.org/Getting_Started/Build/KDE4 Oh, you are right, this really is a junior job, and I am glad you are trying to look into it. When you have a working patch, please add it here or create a review request on https://git.reviewboard.kde.org/ Dotan, I would definitely mentor if you're willing to work on this. You can either post your patch on review board as mentioned by Christoph or just send it to me directly. Git commit 7c599bae516c61365c4eda2be998c97594e3b1af by Victor Polevoy. Committed on 02/07/2013 at 18:45. Pushed by vpolevoy into branch 'master'. Fix typo: 8 instead of 4 keyboard layouts when user trying to add more than 8 keyboard layouts in systemsettings/keyboard. REVIEW: 110285 M +2 -2 kcontrol/keyboard/kcm_keyboard_widget.cpp M +2 -0 kcontrol/keyboard/x11_helper.cpp M +2 -0 kcontrol/keyboard/x11_helper.h http://commits.kde.org/kde-workspace/7c599bae516c61365c4eda2be998c97594e3b1af Thank you Victor! (In reply to comment #6) > Thank you Victor! Developing kde is pleasure for me. |