| Summary: | Brush options change when switching from tablet to mouse or back | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Anna Celarek <blondynka> |
| Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugs_kde_org2, halla |
| Priority: | NOR | ||
| Version: | 2.4-snapshots | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Anna Celarek
2011-11-01 19:09:53 UTC
This is a feature. The brushes are assigned to different input devices. This allows e.g. to have a different brush for the eraser side of the stylus. Now that you mention the eraser, it makes sense of course. Actually a good idea to separate them all (I came across this for eraser and pen, but I think for the mouse I see it the first time). Then the only drawback is, that if I want to type in the size value or opacity value from keyboard, I have to hold the pen 1 cm over the tablet, otherwise the typed in value is assigned to the mouse. (that's actually where I noticed this behaviour first). Typing while balancing the pen at low height is not intuitive or convenient, but I have no idea how that could be solved without destroying the rest of the feature. maybe it's more intuitive, if the mouse just uses the values of the last input device? what does other artists say? It also looks like having different tools with different input devices is going to be a problem with xinput2, so we might have to get rid of it: https://bugs.kde.org/show_bug.cgi?id=283130. I'm not an artist, but when I use Krita these days, I'm actually confused myself by the change between tools and settings when switching from mouse to stylus and back. And the eraser button makes it so easy to start erasing that I never flip my stylus anymore... i don't know, if artists are using this, but if they have 2 different pens, it should switch the tool (e.g. i take first pen and draw with some settings, then i take another, which has a different ending/feeling and it should switch the tool/preset). I think #3 is a good idea - switching only between pen / eraser / another pen, but the mouse should use the settings of the last input device, and settings changed by the mouse should be applied to that last device. Gah, I'm seeing how this works on Ubuntu these days -- and I think we will really have to remove having different tool instances per input device. Maybe we can then later on come up with different config settings, but the tool switching makes every Calligra application impossible to use with a tablet on *buntu 11.10. Git commit eab5746f9f94b48f67ec20cc6d28e9221c53fef1 by Boudewijn Rempt. Committed on 09/11/2011 at 14:25. Pushed by rempt into branch 'master'. KoToolManager: only switch tools between tablet devices This solves two bugs: * On Ubuntu, the xinput system seems to be broken. We are getting tablet events with unknown device/unknown pointer. If we assume that this means that we're actually getting mouse events, everything works fine. * Users prefer to be able to use the mouse sometimes to set the values for the tools and options, and then use the stylus again to paint. So do not switch back to mouse from tablet device, ever. We now also save on activating a single-shot timer a lot of times. BUG:285501 BUG:283130 M +5 -2 libs/flake/KoInputDevice.cpp M +5 -11 libs/flake/KoToolManager.cpp M +0 -2 libs/flake/KoToolManager_p.h http://commits.kde.org/calligra/eab5746f9f94b48f67ec20cc6d28e9221c53fef1 |