| Summary: | Invalid pointer access by commit 02cf7ee8 | ||
|---|---|---|---|
| Product: | [Unmaintained] Network Management | Reporter: | Will Stephenson <wstephenson> |
| Component: | Plasma Widget | Assignee: | Sebastian Kügler <sebas> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | christian.jann, cikasole, danaivehr, g, hanke, jens.churchill+kdebug, lamarque, masterjet, patoche.smart+kde, private.email, roarl, roger.luedecke, tosiara, wolfblitz, wstephenson, xavier.besnard |
| Priority: | NOR | ||
| Version: | 0.9 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.8.98 (0.9.0_rc3) | |
| Sentry Crash Report: | |||
| Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi |
||
Git commit b584c6aff8b70e62ad78da3efb34b0347a67095e by Lamarque V. Souza. Committed on 29/10/2011 at 20:26. Pushed by lvsouza into branch 'master'. Cache NetworkManager::Device's uni to prevent crashes when resuming from disk and the device pointer has already been deleted but the uni is still needed for clean up. BUG: 285255 M +41 -18 applet/networkmanager.cpp M +7 -0 applet/networkmanager.h M +1 -1 plasma_nm_version.h http://commits.kde.org/networkmanagement/b584c6aff8b70e62ad78da3efb34b0347a67095e Git commit 4bca48877d4c4679cc444f533fbcd54852c09f4a by Lamarque V. Souza. Committed on 29/10/2011 at 20:26. Pushed by lvsouza into branch 'nm09'. Cache Solid::Control::NetworkInterface's uni to prevent crashes when resuming from disk and the device pointer has already been deleted but the uni is still needed for clean up. BUG: 285255 M +41 -18 applet/networkmanager.cpp M +7 -0 applet/networkmanager.h M +1 -1 plasma_nm_version.h http://commits.kde.org/networkmanagement/4bca48877d4c4679cc444f533fbcd54852c09f4a Git commit cfdb122c7d291585d54179f08460ccbe729f9a94 by Lamarque V. Souza. Committed on 29/10/2011 at 22:58. Pushed by lvsouza into branch 'master'. Actually we cannot clear this QString or it will not work as intented. CCBUG: 285255 M +1 -0 applet/interfacedetailswidget.cpp M +0 -4 applet/networkmanager.cpp http://commits.kde.org/networkmanagement/cfdb122c7d291585d54179f08460ccbe729f9a94 Git commit ecc28c8139349b44c63ff625aac49ecbf7842e26 by Lamarque V. Souza. Committed on 29/10/2011 at 22:58. Pushed by lvsouza into branch 'nm09'. Actually we cannot clear this QString or it will not work as intented. CCBUG: 285255 (cherry picked from commit cfdb122c7d291585d54179f08460ccbe729f9a94) M +1 -0 applet/interfacedetailswidget.cpp M +0 -4 applet/networkmanager.cpp http://commits.kde.org/networkmanagement/ecc28c8139349b44c63ff625aac49ecbf7842e26 *** Bug 285644 has been marked as a duplicate of this bug. *** *** Bug 286549 has been marked as a duplicate of this bug. *** *** Bug 287119 has been marked as a duplicate of this bug. *** *** Bug 287154 has been marked as a duplicate of this bug. *** *** Bug 287290 has been marked as a duplicate of this bug. *** *** Bug 287306 has been marked as a duplicate of this bug. *** *** Bug 287389 has been marked as a duplicate of this bug. *** *** Bug 287686 has been marked as a duplicate of this bug. *** *** Bug 287947 has been marked as a duplicate of this bug. *** Created attachment 66340 [details]
New crash information added by DrKonqi
plasma-desktop (0.4) on KDE Platform 4.7.2 (4.7.2) "release 5" using Qt 4.7.4
- What I was doing when the application crashed:
Fresh install of suse 12.1 on Thinkpad X220. Closed the lid, opened it -> Crash. 100% Reproducable. Can I please get a software update soon?
- Unusual behavior I noticed:
Nothing before the crash
- Custom settings of the application:
Nothing special
-- Backtrace (Reduced):
#6 Solid::Control::NetworkInterfaceNm09::uni (this=0x0) at /usr/src/debug/networkmanagement/solidcontrolfuture/libs/solid/control/networkinterface.cpp:65
#7 0x00007f386ab50a70 in NetworkManagerApplet::networkInterfaceRemoved (this=0x100b8b0, uni=...) at /usr/src/debug/networkmanagement/applet/networkmanager.cpp:501
#8 0x00007f386ab523fa in NetworkManagerApplet::qt_metacall (this=0x100b8b0, _c=QMetaObject::InvokeMetaMethod, _id=<optimized out>, _a=0x7fff52cfd990) at /usr/src/debug/networkmanagement/build/applet/networkmanager.moc:126
[...]
#10 0x00007f386a02e185 in Solid::Control::NetworkManagerNm09::Notifier::networkInterfaceRemoved (this=<optimized out>, _t1=<optimized out>) at /usr/src/debug/networkmanagement/build/solidcontrolfuture/libs/solid/control/networkmanager.moc:123
#11 0x00007f386a02e6e1 in Solid::Control::NetworkManagerNm09Private::_k_networkInterfaceRemoved (this=0xff3360, uni=...) at /usr/src/debug/networkmanagement/solidcontrolfuture/libs/solid/control/networkmanager.cpp:229
Created attachment 66447 [details]
New crash information added by DrKonqi
plasma-desktop (0.4) on KDE Platform 4.7.2 (4.7.2) "release 5" using Qt 4.7.4
- What I was doing when the application crashed:
Resumed my computer from suspend to RAM after it automatically suspended due to battery power running low.
-- Backtrace (Reduced):
#6 Solid::Control::NetworkInterfaceNm09::uni (this=0x0) at /usr/src/debug/networkmanagement/solidcontrolfuture/libs/solid/control/networkinterface.cpp:65
#7 0x00007f97a68e4a70 in NetworkManagerApplet::networkInterfaceRemoved (this=0xf5c230, uni=...) at /usr/src/debug/networkmanagement/applet/networkmanager.cpp:501
#8 0x00007f97a68e63fa in NetworkManagerApplet::qt_metacall (this=0xf5c230, _c=QMetaObject::InvokeMetaMethod, _id=<optimized out>, _a=0x7fff647380b0) at /usr/src/debug/networkmanagement/build/applet/networkmanager.moc:126
[...]
#10 0x00007f97a5dc2185 in Solid::Control::NetworkManagerNm09::Notifier::networkInterfaceRemoved (this=<optimized out>, _t1=<optimized out>) at /usr/src/debug/networkmanagement/build/solidcontrolfuture/libs/solid/control/networkmanager.moc:123
#11 0x00007f97a5dc26e1 in Solid::Control::NetworkManagerNm09Private::_k_networkInterfaceRemoved (this=0xf4b1a0, uni=...) at /usr/src/debug/networkmanagement/solidcontrolfuture/libs/solid/control/networkmanager.cpp:229
*** Bug 288738 has been marked as a duplicate of this bug. *** *** Bug 288820 has been marked as a duplicate of this bug. *** *** Bug 289903 has been marked as a duplicate of this bug. *** *** Bug 290530 has been marked as a duplicate of this bug. *** |
Version: 0.9 (using KDE 4.7.2) OS: Linux PNM crashes plasma on resume from suspend. The reason is commit 02cf7ee8, which tries to access the members of m_activeInterface in NetworkManagerApplet::networkInterfaceRemoved(). On networkInterfaceRemoved signal, you must assume that any stored pointers to NetworkInterfaces may be the removed ones and are invalid. void NetworkManagerApplet::networkInterfaceRemoved(const QString & uni) { - Q_UNUSED(uni); // update the tray icon m_interfaces = Solid::Control::NetworkManagerNm09::networkInterfaces(); - KConfigGroup cg = config(); + if (uni == m_activeInterface->uni()) { in this case upon networkInterfaceRemoved, m_activeInterface is invalid. Reproducible: Always Steps to Reproduce: Suspend and resume the machine. Expected Results: No crash.