| Summary: | Duplicate timezones sometimes listed in agenda view. | ||
|---|---|---|---|
| Product: | [Applications] korganizer | Reporter: | Ian Turner <vectro> |
| Component: | agendaview (weekview) | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | winter |
| Priority: | NOR | ||
| Version: | 4.7 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8.0 | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot displaying the bug. | ||
Git commit acfbb4931c55c00d4d848a1365e5ca35849bf080 by Allen Winter. Committed on 11/12/2011 at 04:14. Pushed by winterz into branch 'master'. First part of the fix for bug 285118: - when creating the initial list of choices for the combobox, exclude those timezones we are already have chosen from user prefs - when adding a view timezone, remove that from the combobox choices so the user can't add it again - when removing a view timezone, add that back to the combobox choices CCBUG: 285118 M +7 -1 calendarviews/eventviews/agenda/timescaleconfigdialog.cpp http://commits.kde.org/kdepim/acfbb4931c55c00d4d848a1365e5ca35849bf080 Git commit 482ceef777c75e401ecdc85ac60dda742aff816a by Allen Winter. Committed on 11/12/2011 at 04:43. Pushed by winterz into branch 'master'. remove duplicates from the timezone prefs so now only no longer can you see duplicate timescales (by timezone). also the list of selected timezones is deduped in the listwidget in the dialog. BUG: 285118 FIXED-IN: 4.8.0 M +8 -3 calendarviews/eventviews/agenda/timelabelszone.cpp M +8 -5 calendarviews/eventviews/agenda/timescaleconfigdialog.cpp http://commits.kde.org/kdepim/482ceef777c75e401ecdc85ac60dda742aff816a Allen, does this prevent duplicates from occurring in the case that the local time zone is changed? Based on your description, it looks like the patch will only prevent users from multiply adding time zones to the list. you mean if the user changes the system timezone while KOrganizer is running? I think if the user restarts KOrganizer after the system timezone is changed things will work Sorry, I didn't actually read the patch (only the description). This looks great, thanks! |
Created attachment 64947 [details] Screenshot displaying the bug. Version: 4.7 (using KDE 4.7.2) OS: Linux This bug relates to the "multiple timezones" feature in the agenda view, where rulers for multiple timezones are placed to the left of the agenda itself. Korganizer always places the local timezone, and in addition supports extra timezones, added by right-clicking on the current ruler and selecting "Add Timezones...". This bug occurs when one switches the local timezone to one already added as a supplementary timezone, a common use case for people who frequently travel between time zones. Reproducible: Always Steps to Reproduce: Note: In this example, I use two timezones, America/New York and America/Los Angeles, but any two time zones will elicit the described behavior. 1. Set local timezone to America/New York. 2. Run Korganizer, load agenda view 3. Right-click on ruler, select "Add Timezones..." 4. Select a America/Los Angeles, and click the "+" button, then "OK'. Now the ruler contains America/New York and America/Los Angeles time zones. 5. Close Korganizer. 6. Set local time zone America/Los Angeles. 7. Run Korganizer Actual Results: Two time zone rulers are displayed, both for the "America/Los Angeles" time zone. Expected Results: The America/Los Angeles would ruler would only be displayed once. WORKAROUND: Remove America/Los Angeles as a supplementary time zone, possibly also add America/New York as well. I have also attached a screenshot displaying the defective behavior.