Summary: | Amarok Crashed while trying to copy album of mp3s from local collection to iPod nano 6G [@ Meta::MediaDeviceTrack::prettyUrl] | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | arnd-hendrik.mathias |
Component: | Collections/iPod iPhone | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | aumuell, matej |
Priority: | NOR | ||
Version: | 2.4.3 | ||
Target Milestone: | 2.5 | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.5 | |
Sentry Crash Report: |
Description
arnd-hendrik.mathias
2011-10-24 00:30:25 UTC
Mathias, did it happen just once, or are you able to reproduce the crash? Git commit b39551b9791203b952b30108cbdaea28e4871494 by Matěj Laitl. Committed on 28/10/2011 at 17:09. Pushed by laitl into branch 'master'. MediaDeviceTrack: prevent possible crashes, Handler::Capability fixes When a media device is removed, its collection and handler are destroyed, but its tracks, albums are kept as long as they are referenced. Tracks, albums use QWeakPointer to track deletion of their handler. Ensure that this pointer is always checked before use in MediaDeviceTrack. Also ensure that related Capabilities get destroyed (they should be alredy tracked using QWeakPointer) when handler gets deleted. It did not work previously in cases when Capabilities were created in a thread from handler's. Move them to handler's thread so that parentship can be established. BUG: 284838 FIXED-IN: 2.5 M +1 -0 ChangeLog M +26 -18 src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp M +10 -0 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandlerCapability.cpp M +3 -4 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandlerCapability.h http://commits.kde.org/amarok/b39551b9791203b952b30108cbdaea28e4871494 |