Bug 284410

Summary:	Says file "Document called xxx already exists" when saving a file.
Product:	[Applications] kolourpaint	Reporter:	Goran Brannstrom <goranbr>
Component:	general	Assignee:	kolourpaint-support
Status:	RESOLVED FIXED
Severity:	normal	CC:	cfeck
Priority:	NOR
Version:	Comes with KDE
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Goran Brannstrom 2011-10-18 21:09:24 UTC

Version: Comes with KDE (using KDE 4.7.2)
OS: Linux

Apart from the fact that Kolourpaint does not have an inkling where a file it is editing came from (reported previously), it also warns you, saying "Document called xxx already exists. Do you want to overwrite it?" without any reason, when you are just doing a normal "Save" operation. When doing a "Save as.." this might be an expected warning, since you will normally want to make a copy then, but not when just saving a file after editing it using "Save".

Reproducible: Always

Steps to Reproduce:
Right-click on a jpeg-file in Dolphin, chose "Open with..", and Kolurpaint. Make any editing and press "Save".

Actual Results:
Kolourpaint will not just erroneously open a Save Dialog instead of just saving it, and in the current dir, not the source dir, which I have already reported, but... and this is the new bug: if you take the trouble to find the dir where it currently located and try to save it to its original file name, it will actually warn you that you are saving the file by its current name. What is the harm in that? That is what you want to do 99% of the time. Why warn?

Expected Results:
As in related bugs, when pressing Save it should (pretty please..:-) just save the file using its current file path. No dialogs, no warnings, no bells, no whistles, no nothing, unless there is a real show-stopping problem at hand... Like permission problems or the hard disk spontaneously catching fire. :-D

I use Kubuntu, not Ubuntu. But there was no choice for that in the menu.

Comment 1 Christoph Feck 2011-10-18 23:51:51 UTC

> when pressing Save it should (pretty please..:-) just save

I guess the reason for showing the "Save As" dialog even for the Save action is to make you aware which file in which directory you are overwriting, since it does not create backup files (and considering the size of images, I doubt it should).

Comment 2 Christoph Feck 2011-10-19 00:06:41 UTC

Well, I tested a bit, and when using PNG files, it works "as expected", while with JPEG files, it always asks. The explanation might be to be able to set the Quality setting, or just making you aware that you should change the format to something lossess, because every save of a JPEG file degrades quality (even if you increase the quality setting...)

Comment 3 Goran Brannstrom 2011-10-19 11:38:36 UTC

Thanks for feedback!

Re: comment1: I use this application for hours every day and it's exceedingly annoying with all the non-standard behaviour regarding files, when you just want to make a small change, and then save that before exiting. If you want backup, you can just choose "Save as..." instead. Why have the distinction between "Save" and "Save as" otherwise? And why change a behavior that 99% of all applications comply with?

Re: comment2: Well, I don't think a developer should presume to deviate from a standard that 99% of other software adheres to for the sole reason that he thinks the user should save using a lossless format instead. If that is the case here. Only the user can know what suits his needs best.

/Göran

Comment 4 Martin Koller 2011-10-26 14:02:44 UTC

Git commit 25bfb7208fafad76ed953260ccb88123dd9e18a8 by Martin Koller.
Committed on 26/10/2011 at 15:49.
Pushed by mkoller into branch 'KDE/4.7'.

use directory of loaded file in saveAs dialog again

(Sorry for having messed this up in 4.7.0)

BUG: 284890
BUG: 284410
BUG: 277168

M  +2    -2    mainWindow/kpMainWindow_File.cpp

http://commits.kde.org/kolourpaint/25bfb7208fafad76ed953260ccb88123dd9e18a8

Comment 5 Martin Koller 2011-10-26 14:02:44 UTC

Git commit 8991692a54ab1d1b0111a61d7fb39cdb1ac9cdb1 by Martin Koller.
Committed on 26/10/2011 at 15:49.
Pushed by mkoller into branch 'master'.

use directory of loaded file in saveAs dialog again

(Sorry for having messed this up in 4.7.0)

BUG: 284890
BUG: 284410
BUG: 277168

M  +2    -2    mainWindow/kpMainWindow_File.cpp

http://commits.kde.org/kolourpaint/8991692a54ab1d1b0111a61d7fb39cdb1ac9cdb1